Bug 1457814 - Bug in engine.log FenceVdsVDSCommandParameters message
Summary: Bug in engine.log FenceVdsVDSCommandParameters message
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Backend.Core
Version: 4.1.3
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-4.1.4
: 4.1.4
Assignee: Eli Mesika
QA Contact: Israel Pinto
URL:
Whiteboard:
Depends On:
Blocks: oVirt-Metrics-and-Logs
TreeView+ depends on / blocked
 
Reported: 2017-06-01 11:11 UTC by Shirly Radco
Modified: 2017-07-28 14:18 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-07-28 14:18:31 UTC
oVirt Team: Infra
Embargoed:
rule-engine: ovirt-4.1+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 78621 0 master MERGED core: fixing FenceAgent toString 2017-06-27 07:51:03 UTC
oVirt gerrit 78695 0 ovirt-engine-4.1 MERGED core: fixing FenceAgent toString 2017-06-27 14:15:58 UTC

Description Shirly Radco 2017-06-01 11:11:17 UTC
Description of problem:

There is an unwanted newline in the log message that causes the parsing of the log to break when we want to collect it to the central metrics store.

Example:

2017-06-01 12:11:12,429+03 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.FenceVdsVDSCommand] (DefaultQuartzScheduler3) [5839f6a4] START, FenceVdsVDSCommand(HostName = hp-dl360g8-01, FenceVdsVDSCommandParameters:{runAsync='true', hostId='9e836081-35a1-432f-9256-6562c99d5665', targetVdsId='f1c2e1c8-b6f6-4b88-bd40-11e072412844', action='STATUS', agent='FenceAgent:{id='00000371-0371-0371-0371-000000000612', hostId='f1c2e1c8-b6f6-4b88-bd40-11e072412844', order='1', type='ipmilan', ip='dell-r420-02-mm.lab.eng.brq.redhat.com', port='null', user='root', password='***', encryptOptions='false', options='privlvl=OPERATOR
delay=10
lanplus=1'}', policy='null'}), log id: 61a2c2ee

Version-Release number of selected component (if applicable):
4.1.2

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:
The log is split to 2 lines

Expected results:
Should be the same format as the other logs and have only one line,


Additional info:

Comment 1 Martin Perina 2017-06-01 12:39:42 UTC
Hmm, did you set any custom fence agent options in UI?

Comment 2 Shirly Radco 2017-06-04 12:09:06 UTC
This is rhev-tlv engine.log

Comment 3 Israel Pinto 2017-07-16 14:19:38 UTC
How i can invoke this command? 
I need reproduce steps.

Comment 4 Israel Pinto 2017-07-16 14:29:01 UTC
Verify with: 4.1.4.1-0.1.el7

2017-07-15 04:39:39,795+03 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.FenceVdsVDSCommand] (default task-26) [hosts_update_29104427-f2ef-4a96] START, FenceVdsVDSCommand(HostName = host_mixed_2, FenceVdsVDSCommandParameters:{runAsync='true', hostId='76e307a1-a7e3-4374-84ca-ee32f6dcb485', targetVdsId='79c03b7c-0c2e-4984-a820-b5736c4ed1c4', action='STATUS', agent='FenceAgent:{id='9a4239a1-0f80-4714-ab9b-1c66d9c97957', hostId='79c03b7c-0c2e-4984-a820-b5736c4ed1c4', order='1', type='ipmilan', ip='10.35.35.35', port='null', user='user1', password='***', encryptOptions='false', options=''}', policy='null'}), log id: 53f4c6a9

all in one line on break lines. (view with geany editor)


Note You need to log in before you can comment on or make changes to this bug.