Bug 1457901 - nlc_lookup_cbk floods logs
Summary: nlc_lookup_cbk floods logs
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: unclassified
Version: 3.11
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ravishankar N
QA Contact:
URL:
Whiteboard:
Depends On: 1456653
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-06-01 13:36 UTC by Ravishankar N
Modified: 2017-06-28 18:31 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.11.1
Clone Of: 1456653
Environment:
Last Closed: 2017-06-28 18:31:46 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Ravishankar N 2017-06-01 13:36:16 UTC
+++ This bug was initially created as a clone of Bug #1456653 +++

Description of problem:

    For nameless lookups, nl-cache does not init frame local, so the cbk
    throws up messages like these flooding the logs, especially whenenver
    gfid lookup on '/' is done (i.e. loc.path="/" and loc.gfid=1).

    [2017-05-30 04:35:31.628443] E [nl-cache.c:201:nlc_lookup_cbk]
    (-->/usr/lib64/glusterfs/3.8.4/xlator/performance/io-cache.so(+0x3d81)
    [0x7f0883005d81]
    -->/usr/lib64/glusterfs/3.8.4/xlator/performance/quick-read.so(+0x3127)
    [0x7f0882dfb127]
    -->/usr/lib64/glusterfs/3.8.4/xlator/performance/nl-cache.so(+0x4cd3)
    [0x7f08829e0cd3] ) 0-distrep-nl-cache: invalid argument: local [Invalid

--- Additional comment from Worker Ant on 2017-05-30 01:00:55 EDT ---

REVIEW: https://review.gluster.org/17417 (nl-cache: Initialze frame local before stack wind) posted (#1) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2017-05-30 04:19:11 EDT ---

REVIEW: https://review.gluster.org/17417 (nl-cache: Initialze frame local before stack wind) posted (#2) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2017-05-30 05:09:38 EDT ---

REVIEW: https://review.gluster.org/17417 (nl-cache: Remove null check validation for frame->local in lookup cbk) posted (#3) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2017-05-30 11:34:55 EDT ---

COMMIT: https://review.gluster.org/17417 committed in master by Jeff Darcy (jeff.us) 
------
commit ec86167d09bcbb763e31b73fb3d688efaa5444d7
Author: Ravishankar N <ravishankar>
Date:   Tue May 30 10:18:04 2017 +0530

    nl-cache: Remove null check validation for frame->local in lookup cbk
    
    For nameless lookups, nl-cache does not init frame local, so the cbk
    throws up messages like these flooding the logs, especially whenenver
    gfid lookup on '/' is done (i.e. loc.path="/" and loc.gfid=1).
    
    [2017-05-30 04:35:31.628443] E [nl-cache.c:201:nlc_lookup_cbk]
    (-->/usr/lib64/glusterfs/3.8.4/xlator/performance/io-cache.so(+0x3d81)
    [0x7f0883005d81]
    -->/usr/lib64/glusterfs/3.8.4/xlator/performance/quick-read.so(+0x3127)
    [0x7f0882dfb127]
    -->/usr/lib64/glusterfs/3.8.4/xlator/performance/nl-cache.so(+0x4cd3)
    [0x7f08829e0cd3] ) 0-distrep-nl-cache: invalid argument: local [Invalid
    argument]
    
    Fixed it.
    
    Change-Id: I21cb44a9d2a324617e43f46fed83c9a0942d3a0b
    BUG: 1456653
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: https://review.gluster.org/17417
    Tested-by: Pranith Kumar Karampuri <pkarampu>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Poornima G <pgurusid>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 1 Worker Ant 2017-06-01 13:36:57 UTC
REVIEW: https://review.gluster.org/17446 (nl-cache: Remove null check validation for frame->local in lookup cbk) posted (#1) for review on release-3.11 by Ravishankar N (ravishankar)

Comment 2 Worker Ant 2017-06-06 12:54:30 UTC
COMMIT: https://review.gluster.org/17446 committed in release-3.11 by Shyamsundar Ranganathan (srangana) 
------
commit 42f325c3284482899e8d9f72f9beb8cf00294d43
Author: Ravishankar N <ravishankar>
Date:   Tue May 30 10:18:04 2017 +0530

    nl-cache: Remove null check validation for frame->local in lookup cbk
    
    For nameless lookups, nl-cache does not init frame local, so the cbk
    throws up messages like these flooding the logs, especially whenenver
    gfid lookup on '/' is done (i.e. loc.path="/" and loc.gfid=1).
    
    [2017-05-30 04:35:31.628443] E [nl-cache.c:201:nlc_lookup_cbk]
    (-->/usr/lib64/glusterfs/3.8.4/xlator/performance/io-cache.so(+0x3d81)
    [0x7f0883005d81]
    -->/usr/lib64/glusterfs/3.8.4/xlator/performance/quick-read.so(+0x3127)
    [0x7f0882dfb127]
    -->/usr/lib64/glusterfs/3.8.4/xlator/performance/nl-cache.so(+0x4cd3)
    [0x7f08829e0cd3] ) 0-distrep-nl-cache: invalid argument: local [Invalid
    argument]
    
    Fixed it.
    
    > Reviewed-on: https://review.gluster.org/17417
    > Tested-by: Pranith Kumar Karampuri <pkarampu>
    > Smoke: Gluster Build System <jenkins.org>
    > Reviewed-by: Poornima G <pgurusid>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    (cherry picked from commit ec86167d09bcbb763e31b73fb3d688efaa5444d7)
    
    Change-Id: I21cb44a9d2a324617e43f46fed83c9a0942d3a0b
    BUG: 1457901
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: https://review.gluster.org/17446
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Poornima G <pgurusid>

Comment 3 Shyamsundar 2017-06-28 18:31:46 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.1, please open a new bug report.

glusterfs-3.11.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-June/000074.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.