Red Hat Bugzilla – Bug 1457909
[NMCI] nm doesn't match bond connection and a device
Last modified: 2017-08-01 05:28:57 EDT
Description of problem: nm-bond doesn't match connection after service restart ip l add bond123 type bond; cat /sys/class/net/bond123/bonding/tlb_dynamic_lb 7.3: 0 7.4: 1 Version-Release number of selected component (if applicable): 1.8.0-4 How reproducible: bond_addreses_restart_persistence
Created attachment 1284209 [details] [PATCH] bond: ignore tlb_dynamic_lb for non-tlb modes
(In reply to Beniamino Galvani from comment #2) > Created attachment 1284209 [details] > [PATCH] bond: ignore tlb_dynamic_lb for non-tlb modes - while (options && *options) { + for (; options && *options; options++) { options cannot be NULL (ever). Can we change that too? Otherwise, lgtm
(In reply to Thomas Haller from comment #3) > (In reply to Beniamino Galvani from comment #2) > > Created attachment 1284209 [details] > > [PATCH] bond: ignore tlb_dynamic_lb for non-tlb modes > > - while (options && *options) { > + for (; options && *options; options++) { > > options cannot be NULL (ever). Can we change that too? Okay. I realized there was a missing part: if the connection has bond.options "mode=balance-rr,tlb_dynamic_lb=2" (which is a weird configuration, but it is accepted), it will never match on restart because the generated connection doesn't have the 'tlb_dynamic_lb' option. Added a commit to remove unsupported options from connection upon normalization.
bg/bond-tlb-dynamic-lb-option-rh1457909 lgtm.
Upstream: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=4be0cdd358a9253e874eaaf9e244339d8fc6aa33 (renamed the branch to a more appropriate 'bg/bond-option-normalize-rh1457909')
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2017:2299