Bug 1458197 - io-stats usability/performance statistics enhancements
Summary: io-stats usability/performance statistics enhancements
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: GlusterFS
Classification: Community
Component: io-stats
Version: mainline
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
Assignee: Krutika Dhananjay
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-06-02 09:41 UTC by Krutika Dhananjay
Modified: 2020-02-06 09:41 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.12.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-02-06 09:41:32 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Krutika Dhananjay 2017-06-02 09:41:40 UTC
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-06-02 10:23:18 UTC
REVIEW: https://review.gluster.org/17451 (debug/io-stats: Provide option to select stats output format) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 2 Worker Ant 2017-06-02 10:23:23 UTC
REVIEW: https://review.gluster.org/17452 (debug/io-stats: Append stats for each interval in the same file) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 3 Worker Ant 2017-06-05 05:07:44 UTC
REVIEW: https://review.gluster.org/17451 (debug/io-stats: Provide option to select stats output format) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

Comment 4 Worker Ant 2017-06-08 13:49:09 UTC
REVIEW: https://review.gluster.org/17452 (debug/io-stats: Append stats for each interval in the same file) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

Comment 5 Worker Ant 2017-06-09 05:03:53 UTC
REVIEW: https://review.gluster.org/17451 (debug/io-stats: Provide option to select stats output format) posted (#3) for review on master by Krutika Dhananjay (kdhananj)

Comment 6 Worker Ant 2017-06-15 19:18:09 UTC
COMMIT: https://review.gluster.org/17451 committed in master by Shyamsundar Ranganathan (srangana) 
------
commit b9fb7ea63d6120faaeb75ffa0cafbc0ab0e4a619
Author: Krutika Dhananjay <kdhananj>
Date:   Fri May 26 15:56:59 2017 +0530

    debug/io-stats: Provide option to select stats output format
    
    ... as opposed to hardcoding it to "json" always.
    
    Change-Id: I5e79473a514373145ad764f24bb6219a6983a4c6
    BUG: 1458197
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: https://review.gluster.org/17451
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 7 Worker Ant 2017-07-06 14:16:30 UTC
COMMIT: https://review.gluster.org/17452 committed in master by Shyamsundar Ranganathan (srangana) 
------
commit fc73ae5f81ef5926e3dc2311db116250d0f2a321
Author: Krutika Dhananjay <kdhananj>
Date:   Fri Jun 2 15:42:39 2017 +0530

    debug/io-stats: Append stats for each interval in the same file
    
    ... instead of overwriting stats from the previous interval.
    This is so that consumers of this feature do not have to be worried
    about monitoring when each 'ios-dump-interval' has passed and back up
    the resultant stats file well before the next interval has expired.
    
    Change-Id: Ide897237bf4d38e5d759f09911f7d9c817019edf
    BUG: 1458197
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: https://review.gluster.org/17452
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Amar Tumballi <amarts>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 8 Shyamsundar 2017-09-05 17:33:02 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.12.0, please open a new bug report.

glusterfs-3.12.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-September/000082.html
[2] https://www.gluster.org/pipermail/gluster-users/

Comment 9 Worker Ant 2017-11-20 18:39:01 UTC
REVIEW: https://review.gluster.org/18814 (debug/io-stats: provide option to open file mode) posted (#2) for review on master by Amar Tumballi

Comment 10 Amar Tumballi 2017-11-22 10:10:09 UTC
reopening as the previous fix caused a regression.

Comment 11 Krutika Dhananjay 2020-02-06 09:41:32 UTC
Closing this, as with an appropriately chosen value for the interval, it won't be necessary to append stats.


Note You need to log in before you can comment on or make changes to this bug.