Bug 1458394 - Re-Review Request: nuvolaruntime - Tight integration of web apps with your desktop, renaming nuvolaplayer
Summary: Re-Review Request: nuvolaruntime - Tight integration of web apps with your de...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Vít Ondruch
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/tiliado/nuvolaruntime
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-06-02 18:12 UTC by MartinKG
Modified: 2017-06-07 09:18 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-06-07 09:18:03 UTC
Type: ---
Embargoed:
vondruch: fedora-review+


Attachments (Terms of Use)

Description MartinKG 2017-06-02 18:12:52 UTC
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvolaruntime.specSRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvolaruntime-4.4.0-1.fc25.src.rpmDescription: <description here>

Fedora Account System Username: martinkg

Description: This is a rename of nuvolaplayer which has had a rename upstream. 
Nuvola Apps™ is a runtime for semi-sandboxed web apps providing more native user experience and tighter integration with Linux desktop environments than usual web browsers can offer. It tries to feel and look like a native application as much as possible. Nuvola™ mostly specializes on music streaming web apps (e.g. Google Play Music, Spotify, Amazon Music, Deezer, nd more), but progress is being made to support generic web apps (e.g. Google Calendar, Google Keep, etc.).

koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19811293

Comment 1 Vít Ondruch 2017-06-05 07:59:51 UTC
You want to use correct Obsoletes/Provides:

https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages

Comment 2 Vít Ondruch 2017-06-05 08:04:23 UTC
Also, you want to adjust the description according to these guidelines:

https://fedoraproject.org/wiki/Packaging:Guidelines#Trademarks_in_Summary_or_Description

Comment 3 MartinKG 2017-06-05 12:46:42 UTC
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvolaruntime.specSRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvolaruntime-4.4.0-2.fc25.src.rpm

%changelog
* Mon Jun 05 2017 Martin Gansser <martinkg> - 4.4.0-2
- remove Trademarks in Description
- add Obsoletes: nuvolaplayer <= 3.1.3-7

Comment 4 Vít Ondruch 2017-06-06 06:27:54 UTC
* Please describe patches
  - You carry aroun nuvoplaruntie-wscript patch, but what is it purpose? Where
    is it coming from? Is it upstreamed or taken from upstream? While you
    probably know, it would be helpful to others to attache 2 line comment
    above the patch to explain the purpose and link the sources. Thx.

* appindicator dependency
  - Is it mandatory? Is it possible to disable it? I don't think this is
    supported by default in Fedora. As far as I understand it, you need Gnome
    Shell KStatusNotifierItem/AppIndicator Support plugin [1] installed to
    benefit from this ...

* Space characters on the end of line
  - There are several lines containing empty space after the end of line. This
    is just minor nit, but probably better to avoid this (the spaces are nicely
    visualized by colorized git diff output).

* waf vs waf-3
  - While the "waf-3" have to be required to pull in the Python3 version of waf,
    I think it should be fine to use the "waf" command. Or do you prefer to be
    explicit about it? I leave it up to you.

* description
  - I'd keep just the first paragraph of the description (i.e. "Nuvola Apps
    is a runtime for semi-sandboxed web apps ...").


Otherwise the package is quite similar to the nuvolaplayer (not surprisingly) and I don't see anything major => APPROVED


[1]: https://extensions.gnome.org/extension/615/appindicator-support/

Comment 5 MartinKG 2017-06-06 08:08:11 UTC
(In reply to Vít Ondruch from comment #4)
> * Please describe patches
>   - You carry aroun nuvoplaruntie-wscript patch, but what is it purpose?
> Where
>     is it coming from? Is it upstreamed or taken from upstream? While you
>     probably know, it would be helpful to others to attache 2 line comment
>     above the patch to explain the purpose and link the sources. Thx.

add description 

> * appindicator dependency
>   - Is it mandatory? Is it possible to disable it? I don't think this is
>     supported by default in Fedora. As far as I understand it, you need Gnome
>     Shell KStatusNotifierItem/AppIndicator Support plugin [1] installed to
>     benefit from this ...

add configure option to disable appindicator

> * Space characters on the end of line
>   - There are several lines containing empty space after the end of line.
> This
>     is just minor nit, but probably better to avoid this (the spaces are
> nicely
>     visualized by colorized git diff output).

removed spaces at EOL

> * waf vs waf-3
>   - While the "waf-3" have to be required to pull in the Python3 version of
> waf,
>     I think it should be fine to use the "waf" command. Or do you prefer to
> be
>     explicit about it? I leave it up to you.

will take waf when commit it to git

> * description
>   - I'd keep just the first paragraph of the description (i.e. "Nuvola Apps
>     is a runtime for semi-sandboxed web apps ...").
> 
shorten the description as you mentioned


> Otherwise the package is quite similar to the nuvolaplayer (not
> surprisingly) and I don't see anything major => APPROVED
> 
> 
> [1]: https://extensions.gnome.org/extension/615/appindicator-support/

thanks for your review


Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvolaruntime.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvolaruntime-4.4.0-3.fc25.src.rpm

Comment 6 Vít Ondruch 2017-06-06 10:08:47 UTC
(In reply to mgansser from comment #5)
> (In reply to Vít Ondruch from comment #4)
> > * Please describe patches
> >   - You carry aroun nuvoplaruntie-wscript patch, but what is it purpose?
> > Where
> >     is it coming from? Is it upstreamed or taken from upstream? While you
> >     probably know, it would be helpful to others to attache 2 line comment
> >     above the patch to explain the purpose and link the sources. Thx.
> 
> add description 

That is perfect. Thx.

> > * description
> >   - I'd keep just the first paragraph of the description (i.e. "Nuvola Apps
> >     is a runtime for semi-sandboxed web apps ...").
> > 
> shorten the description as you mentioned

I would remove the first two lines as well ...

> thanks for your review

YAW

Comment 7 Gwyn Ciesla 2017-06-06 21:30:16 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/nuvolaruntime

Comment 8 MartinKG 2017-06-07 09:18:03 UTC
package has been built successfully on f25, f26 and rawhide.


Note You need to log in before you can comment on or make changes to this bug.