Bug 1458445 - Extra parameter in call to Job#set_status from `VmScan#call_snapshot_delete'
Summary: Extra parameter in call to Job#set_status from `VmScan#call_snapshot_delete'
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: SmartState Analysis
Version: 5.8.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: GA
: 5.8.1
Assignee: Yuri Rudman
QA Contact: Satyajit Bulage
URL:
Whiteboard:
Depends On: 1458371
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-06-02 22:43 UTC by Satoe Imaishi
Modified: 2022-07-09 08:37 UTC (History)
5 users (show)

Fixed In Version: 5.8.1.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1458371
Environment:
Last Closed: 2017-08-02 17:25:36 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2017:1758 0 normal SHIPPED_LIVE Important: Red Hat CloudForms security, bug fix, and enhancement update 2017-08-02 21:23:43 UTC

Comment 2 CFME Bot 2017-06-02 22:51:36 UTC
New commit detected on ManageIQ/manageiq/fine:
https://github.com/ManageIQ/manageiq/commit/08455e1b0e0c2a93b29042c3eeb9018922fa8333

commit 08455e1b0e0c2a93b29042c3eeb9018922fa8333
Author:     Šimon Lukašík <isimluk>
AuthorDate: Wed May 3 10:44:22 2017 +0200
Commit:     Satoe Imaishi <simaishi>
CommitDate: Fri Jun 2 18:45:28 2017 -0400

    Merge pull request #14964 from yrudman/fixed-bug-in-vmscan-set_status
    
    Fixed bug: one call to Job#set_status from `VmScan#call_snapshot_delete' has one extra parameter
    (cherry picked from commit f90652d3d131388ea2819e84c2fbbd431d956f8a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1458445

 app/models/vm_scan.rb       |  2 +-
 spec/models/vm_scan_spec.rb | 25 +++++++++++++++++++++++++
 2 files changed, 26 insertions(+), 1 deletion(-)

Comment 3 Satyajit Bulage 2017-07-04 06:37:57 UTC
Hello Yuri,

Can you please add verification steps.

Thanks,
Satyajit Bulage.

Comment 4 Yuri Rudman 2017-07-05 13:21:42 UTC
Hi Satyajit,

I am not sure about exact steps for recreating this bug. This bug was not discovered during interactive testing but when test coverage were added in https://github.com/ManageIQ/manageiq/pull/14964

this expectation: https://github.com/ManageIQ/manageiq/blob/master/spec/models/vm_scan_spec.rb#L358-L363
was throwing "ArgumentError: wrong number of arguments (given 3, expected 1..2)" 

Thanks,
Yuri

Comment 5 Satyajit Bulage 2017-07-06 16:40:46 UTC
Performed SSA on VM and saw actions related to snapshot create and delete in logs. Getting output in logs "Deleting snapshot: reference: ..." instead of "ArgumentError: wrong number of arguments … ".

Verified Version: 5.8.1.0.20170623170756_3ed4411

Comment 7 errata-xmlrpc 2017-08-02 17:25:36 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:1758


Note You need to log in before you can comment on or make changes to this bug.