Red Hat Bugzilla – Bug 1458445
Extra parameter in call to Job#set_status from `VmScan#call_snapshot_delete'
Last modified: 2017-08-02 13:25:36 EDT
New commit detected on ManageIQ/manageiq/fine: https://github.com/ManageIQ/manageiq/commit/08455e1b0e0c2a93b29042c3eeb9018922fa8333 commit 08455e1b0e0c2a93b29042c3eeb9018922fa8333 Author: Šimon Lukašík <isimluk@fedoraproject.org> AuthorDate: Wed May 3 10:44:22 2017 +0200 Commit: Satoe Imaishi <simaishi@redhat.com> CommitDate: Fri Jun 2 18:45:28 2017 -0400 Merge pull request #14964 from yrudman/fixed-bug-in-vmscan-set_status Fixed bug: one call to Job#set_status from `VmScan#call_snapshot_delete' has one extra parameter (cherry picked from commit f90652d3d131388ea2819e84c2fbbd431d956f8a) https://bugzilla.redhat.com/show_bug.cgi?id=1458445 app/models/vm_scan.rb | 2 +- spec/models/vm_scan_spec.rb | 25 +++++++++++++++++++++++++ 2 files changed, 26 insertions(+), 1 deletion(-)
Hello Yuri, Can you please add verification steps. Thanks, Satyajit Bulage.
Hi Satyajit, I am not sure about exact steps for recreating this bug. This bug was not discovered during interactive testing but when test coverage were added in https://github.com/ManageIQ/manageiq/pull/14964 this expectation: https://github.com/ManageIQ/manageiq/blob/master/spec/models/vm_scan_spec.rb#L358-L363 was throwing "ArgumentError: wrong number of arguments (given 3, expected 1..2)" Thanks, Yuri
Performed SSA on VM and saw actions related to snapshot create and delete in logs. Getting output in logs "Deleting snapshot: reference: ..." instead of "ArgumentError: wrong number of arguments … ". Verified Version: 5.8.1.0.20170623170756_3ed4411
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2017:1758