Description of problem: Rest API doesn't return error in case of auto_storage_select is set to False for existing VM pool Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. Create VM pool with auto_storage_select: True 2. Try to disable auto_storage_select via REST API 3. Actual results: auto_storage_select is enabled, but no error returned Expected results: auto_storage_select flag is enabled, API returns Validation Error with message like : You cannot disable auto_storage_select for existing VM pool Additional info:
it actually does change the value of it, but it should not. So there indeed is a missing validation.
Is it correct behaviour to change it's value? We have and testcase in the polarion that says it can't be update after pool creation https://polarion.engineering.redhat.com/polarion/#/project/RHEVM3/workitem?id=RHEVM-17366&revision=1574780
Since now it can be disabled via REST API but not via UI
It is not a correct behavior to change that value. It has to return a validation error.
Can you give a bit more details on why is it failed qe? I have just tried to use the API to change the auto_storage_select from true to false and have received this msg: <?xml version="1.0" encoding="UTF-8" standalone="yes"?> <fault> <detail>[Cannot change VM-Pool automatic selection of target storage domains during disks allocation.]</detail> <reason>Operation Failed</reason> </fault> Is it not what happens to you? Can you please provide what the API returns on GET of that pool, what you send it to update the pool and what it answers?
Indeed this is true for 4.2.0 But on 4.1.8-0.1.el7 it returns you 200 response code, and says that auto_storage_select parameter was updated
and 4.2 is a release where the bug was fixed
Verified on 4.2.0-0.0.master.20171112130303.git8bc889c.el7.centos
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017. Since the problem described in this bug report should be resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.