Red Hat Bugzilla – Bug 1459181
[BACKPORT] [Neutron] Don't add duplicate metadata rules after router update
Last modified: 2017-08-14 15:07:55 EDT
Description of problem:
- Customer/We still see "Duplicate iptables rule detected" warning messages in l3-agent.log file on OSP10/Newton with 142b68f0 .
- To eliminate it, please introduce upstream fix on https://bugs.launchpad.net/neutron/+bug/1658460
Author: Quan Tian <firstname.lastname@example.org>
Date: Sun Jan 22 16:49:24 2017 +0800
Don't add duplicate metadata rules after router update
For a HA router, when it's updated, the l3 agents which are standby
always call the after_router_added method, then duplicate metadata
rules are added to iptables table. Althrough these rules will not be
applied to system because of the _weed_out_duplicates method, they will
grow linearly with router update operations.
Because these metadata rules are added once router is added to the agent
and will not be cleaned until router is removed, calling the add_rule
method in after_router_updated is a waste.
This patch removes adding metadata rules in after_router_updated.
Version-Release number of selected component (if applicable):
Red Hat OpenStack Platform 10
Steps to Reproduce:
https://review.openstack.org/#/c/473478/ created. Once that merges I'll cherry-pick back to 10.0