Bug 1459553 - python-glareclient - client library for Unified Artifact Repository (Glare)
Summary: python-glareclient - client library for Unified Artifact Repository (Glare)
Alias: None
Product: RDO
Classification: Community
Component: Package Review
Version: trunk
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
: trunk
Assignee: Alfredo Moralejo
QA Contact: hguemar
Depends On:
Blocks: RDO-PIKE
TreeView+ depends on / blocked
Reported: 2017-06-07 12:39 UTC by Mike Fedosin
Modified: 2018-01-09 14:20 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2018-01-09 14:20:28 UTC
amoralej: rdo-review+

Attachments (Terms of Use)

Description Mike Fedosin 2017-06-07 12:39:19 UTC
Packaging for Glare and its client URL: https://github.com/Fedosin/glare-rpm

Glare client spec: https://raw.githubusercontent.com/Fedosin/glare-rpm/master/python-glareclient.spec

Description: Python client for Glare REST API. Includes python library for Glare API, Command Line Interface (CLI) library and openstackclient plugin.

Comment 1 Alfredo Moralejo 2017-08-14 15:39:31 UTC
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
     (v2.0)". 32 files have unknown license. Detailed output of
     licensecheck in /tmp/python-glareclient/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /etc/bash_completion.d(python2-novaclient, stgit,
     python2-glanceclient, yum-utils, bash-completion, filesystem,
     python2-heatclient, udisks, devassistant-cli)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

[x]: Python eggs must not download any dependencies during the build
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python2-glareclient , python-glareclient-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define upstream_version
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).

Checking: python2-glareclient-0.4.2-0.20170814150217.f669aba.el7.centos.noarch.rpm
python2-glareclient.noarch: W: spelling-error %description -l en_US openstackclient -> happenstance
python2-glareclient.noarch: E: no-changelogname-tag
python2-glareclient.noarch: E: zero-length /usr/lib/python2.7/site-packages/glareclient/tests/unit/var/badcert.crt
python2-glareclient.noarch: W: non-conffile-in-etc /etc/bash_completion.d/glare
python2-glareclient.noarch: W: no-manual-page-for-binary glare-2.7
python2-glareclient.noarch: W: no-manual-page-for-binary glare-2
python-glareclient-doc.noarch: W: spelling-error %description -l en_US openstackclient -> happenstance
python-glareclient-doc.noarch: E: no-changelogname-tag
python-glareclient-doc.noarch: W: file-not-utf8 /usr/share/doc/python-glareclient-doc-0.4.2/html/objects.inv
python-glareclient.src: W: spelling-error %description -l en_US openstackclient -> happenstance
python-glareclient.src: E: no-changelogname-tag
python-glareclient.src: W: invalid-url Source0: python-glareclient-0.4.2.dev3-0.20170814150217.f669aba.tar.gz
3 packages and 0 specfiles checked; 4 errors, 8 warnings.

Rpmlint (installed packages)
python2-glareclient.noarch: E: no-changelogname-tag
python2-glareclient.noarch: W: non-conffile-in-etc /etc/bash_completion.d/glare
python2-glareclient.noarch: E: zero-length /usr/lib/python2.7/site-packages/glareclient/tests/unit/var/badcert.crt
python2-glareclient.noarch: W: no-manual-page-for-binary glare-2.7
python2-glareclient.noarch: W: no-manual-page-for-binary glare-2
python-glareclient-doc.noarch: E: no-changelogname-tag
2 packages and 0 specfiles checked; 3 errors, 3 warnings.

python2-glareclient (rpmlib, GLIBC filtered):

python-glareclient-doc (rpmlib, GLIBC filtered):



Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m dlrn-master -rn python-glareclient-0.4.2-0.20170814150217.f669aba.el7.centos.src.rpm
Buildroot used: dlrn-centos-master-x86_64-1
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP

Some comments:

- Package license is valid ASL 2.0
- no-changelogname-tag error: this spec is prepared for DLRN, which doesn't use changelog.
- zero-length /usr/lib/python2.7/site-packages/glareclient/tests/unit/var/badcert.crt is a fixture for unit tests

Package is APPROVED

Note You need to log in before you can comment on or make changes to this bug.