Bug 1459625 - Strange choices in spec file for rpm build.
Summary: Strange choices in spec file for rpm build.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-sdk-python
Classification: oVirt
Component: Packaging.rpm
Version: 4.1.4
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ovirt-4.1.5
: 4.1.6
Assignee: Fabrice Bacchella
QA Contact: Jiri Belka
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-06-07 15:40 UTC by Fabrice Bacchella
Modified: 2017-08-23 08:02 UTC (History)
8 users (show)

Fixed In Version: python-ovirt-engine-sdk4-4.1.6
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-23 08:02:41 UTC
oVirt Team: Infra
Embargoed:
rule-engine: ovirt-4.1+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 77968 0 None None None 2017-06-07 17:23:46 UTC
oVirt gerrit 77981 0 master ABANDONED Removes now useless Provides and Obsoletes from spec.*.in 2017-06-09 07:12:18 UTC
oVirt gerrit 78022 0 master MERGED Removes now useless Provides and Obsoletes from spec.*.in 2017-06-15 07:50:25 UTC
oVirt gerrit 78202 0 sdk_4.1 MERGED Removes now useless Provides and Obsoletes from spec.*.in 2017-06-15 08:01:53 UTC

Description Fabrice Bacchella 2017-06-07 15:40:14 UTC
If I look at https://github.com/oVirt/ovirt-engine-sdk/blob/master/packaging/spec.el7.in,

I see:

Provides: ovirt-engine-sdk = %{version}-%{release}
Obsoletes: ovirt-engine-sdk < 3.3.0.6

It should not provides as a "generic SDK", without python in the name, it's the python sdk.

Both SDK 3 and 4 can be used at the same time, that's why they have different name. So why sdk4 obsoletes the sdk3, preventing to install both at the same time ?

Comment 1 Juan Hernández 2017-06-07 15:55:32 UTC
That is history. Version 3 of the SDK used to be named 'ovirt-engine-sdk', till version 3.3.0.6, when it was renamed to 'ovirt-engine-sdk-python'.

These lines were carried over when version 4 of the SDK was created. They aren't needed and should be removed. However they shouldn't prevent the installation of a recent version 3 of the SDK, as it is named 'ovirt-engine-sdk-python'.

Comment 2 Juan Hernández 2017-06-07 16:19:32 UTC
Care to submit a patch to gerrit to remove those lines from the .spec files? It is simple, and a good way to get familiar with gerrit.

Comment 3 Lukas Svaty 2017-07-11 06:38:56 UTC
Proposing CodeChange as no additional functionality was added nor removed.

Comment 4 Jiri Belka 2017-08-07 07:54:06 UTC
ok, python-ovirt-engine-sdk4-4.1.6-1

no more Provides & Obsoletes in the spec file

# rpm2cpio python-ovirt-engine-sdk4-4.1.6-1.el7ev.src.rpm | cpio --to-stdout -i python-ovirt-engine-sdk4.spec 2>/dev/null | grep -qE '^(Provides|Obsoletes)' ; echo $?
1


Note You need to log in before you can comment on or make changes to this bug.