Bug 1460174 - Review Request: libopusenc - A library that provides an easy way to encode Ogg Opus files
Summary: Review Request: libopusenc - A library that provides an easy way to encode Og...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-06-09 10:29 UTC by Peter Robinson
Modified: 2017-06-09 21:33 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-06-09 21:33:45 UTC
Type: Bug
Embargoed:
zbyszek: fedora-review+

Attachments (Terms of Use)

Description Peter Robinson 2017-06-09 10:29:20 UTC 
SPEC: https://pbrobinson.fedorapeople.org/libopusenc.spec
SRPM: https://pbrobinson.fedorapeople.org/libopusenc-0.1-1.fc26.src.rpm
Decscription:
A library that provides an easy way to encode Ogg Opus files.

koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=19925262
Comment 1 Zbigniew Jędrzejewski-Szmek 2017-06-09 14:00:31 UTC 
URL is messed up. Also, no https?

Suggestion: make %{?_smp_mflags} V=1 → %make_build
Suggestion: make install DESTDIR=%{buildroot} → %make_install

+ package name is OK
+ license is acceptable for Fedora (BSD)
+ license is specified correctly
+ builds and install OK
+ fedora-review finds no issues
+ scriptlets are correct
+ R/BR/P look correct
+ %check is present and passes

Package is APPROVED. Please note the comments at the top.
Comment 2 Peter Robinson 2017-06-09 14:23:05 UTC 
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> URL is messed up. Also, no https?
> 
> Suggestion: make %{?_smp_mflags} V=1 → %make_build
> Suggestion: make install DESTDIR=%{buildroot} → %make_install

All fixed locally, will be fixed on initial checkin. Thanks!
Comment 3 Gwyn Ciesla 2017-06-09 15:36:12 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/libopusenc
Note You need to log in before you can comment on or make changes to this bug.