Bug 1460174 - Review Request: libopusenc - A library that provides an easy way to encode Ogg Opus files
Review Request: libopusenc - A library that provides an easy way to encode Og...
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Zbigniew Jędrzejewski-Szmek
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-06-09 06:29 EDT by Peter Robinson
Modified: 2017-06-09 17:33 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-06-09 17:33:45 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
zbyszek: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Peter Robinson 2017-06-09 06:29:20 EDT
SPEC: https://pbrobinson.fedorapeople.org/libopusenc.spec
SRPM: https://pbrobinson.fedorapeople.org/libopusenc-0.1-1.fc26.src.rpm
Decscription:
A library that provides an easy way to encode Ogg Opus files.

koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=19925262
Comment 1 Zbigniew Jędrzejewski-Szmek 2017-06-09 10:00:31 EDT
URL is messed up. Also, no https?

Suggestion: make %{?_smp_mflags} V=1 → %make_build
Suggestion: make install DESTDIR=%{buildroot} → %make_install

+ package name is OK
+ license is acceptable for Fedora (BSD)
+ license is specified correctly
+ builds and install OK
+ fedora-review finds no issues
+ scriptlets are correct
+ R/BR/P look correct
+ %check is present and passes

Package is APPROVED. Please note the comments at the top.
Comment 2 Peter Robinson 2017-06-09 10:23:05 EDT
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> URL is messed up. Also, no https?
> 
> Suggestion: make %{?_smp_mflags} V=1 → %make_build
> Suggestion: make install DESTDIR=%{buildroot} → %make_install

All fixed locally, will be fixed on initial checkin. Thanks!
Comment 3 Gwyn Ciesla 2017-06-09 11:36:12 EDT
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/libopusenc

Note You need to log in before you can comment on or make changes to this bug.