Bug 1460512 - Useless log about removed luns is printed although no luns were removed
Summary: Useless log about removed luns is printed although no luns were removed
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: future
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ovirt-4.1.3
: 4.1.3.3
Assignee: Idan Shaby
QA Contact: Kevin Alon Goldblatt
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-06-11 15:31 UTC by Idan Shaby
Modified: 2017-07-06 13:35 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-07-06 13:35:51 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.1+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 78064 0 master MERGED backend: fix log with empty removed luns list 2017-06-11 16:53:56 UTC
oVirt gerrit 78069 0 ovirt-engine-4.1 MERGED backend: fix log with empty removed luns list 2017-06-12 08:07:25 UTC

Description Idan Shaby 2017-06-11 15:31:02 UTC
Description of problem:
When synchronizing a storage domain, the following log is printed: "Removed LUNs, IDs ''" (with an empty list of luns' IDs).

Version-Release number of selected component (if applicable):
c86d08a6dabbfc83952370e347e266917778068e

How reproducible:
100%

Steps to Reproduce:
1. Activate a block domain that was previously on maintenance.
2. Watch the log and see that as a part of the execution of SyncLunsInfoForBlockStorageDomainCommand, the useless log is printed.

Actual results:
"Removed LUNs, IDs ''"

Expected results:
No log about removed luns should be printed when no luns were removed.

Comment 1 Allon Mureinik 2017-06-11 15:36:30 UTC
Low hanging fruit in a new feature - let's backport this to 4.1.z too please.

Comment 2 Allon Mureinik 2017-06-20 10:02:02 UTC
This patch is included in the ovirt-engine-4.1.3.3 tag.

Comment 3 Kevin Alon Goldblatt 2017-06-20 15:51:58 UTC
Verified with the following code:
------------------------------------
ovirt-engine-4.1.3.4-0.1.el7.noarch
rhevm-4.1.3.4-0.1.el7.noarch
vdsm-4.19.19-1.el7ev

Steps to Reproduce:
-----------------------
1. Activate a block domain that was previously on maintenance.
2. Watch the log and see that as a part of the execution of SyncLunsInfoForBlockStorageDomainCommand, the useless log is printed.

Actual results:
No log about removed luns should be printed when no luns were removed.


Moving to VERIFIED!


Note You need to log in before you can comment on or make changes to this bug.