Bug 1460649 - posix-acl: Whitelist virtual ACL xattrs
Summary: posix-acl: Whitelist virtual ACL xattrs
Keywords:
Status: CLOSED EOL
Alias: None
Product: GlusterFS
Classification: Community
Component: posix-acl
Version: 3.10
Hardware: All
OS: All
unspecified
high
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On: 1459971 1460650
Blocks: glusterfs-3.10.4 1459972 1460647
TreeView+ depends on / blocked
 
Reported: 2017-06-12 10:35 UTC by Soumya Koduri
Modified: 2018-06-20 18:29 UTC (History)
2 users (show)

Fixed In Version:
Clone Of: 1459971
Environment:
Last Closed: 2018-06-20 18:29:33 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Soumya Koduri 2017-06-12 10:35:32 UTC
+++ This bug was initially created as a clone of Bug #1459971 +++

Description of problem:

Similar to system.posix_acl_* xattrs, all users should be able to read virtual acl xattrs too (glusterfs.posix-acl-*). 

Otherwise it shall result in EACCESS error when any non-root user is trying to ACL of any file created under gluster volume.

Version-Release number of selected component (if applicable):


How reproducible:
Always


Steps to Reproduce:
1. Start NFS-ganesha using a non-root user
2. Export a volume via NFS-Ganesha
3. Mount the volume using NFSv4
4. Try to read/get acl.


Actual results:
It results in "Permission denied" error.

Expected results:
All users should be able to read POSIX ACLs for any file.

Additional info:

--- Additional comment from Worker Ant on 2017-06-08 13:28:48 EDT ---

REVIEW: https://review.gluster.org/17493 (posix-acl: Whitelist virtual ACL xattrs) posted (#1) for review on master by soumya k (skoduri)

--- Additional comment from Worker Ant on 2017-06-09 07:10:05 EDT ---

COMMIT: https://review.gluster.org/17493 committed in master by Niels de Vos (ndevos) 
------
commit 68f2192df570b5ee615d440c2e0c88d49a75a34f
Author: Soumya Koduri <skoduri>
Date:   Thu Jun 8 22:19:17 2017 +0530

    posix-acl: Whitelist virtual ACL xattrs
    
    Similar to system.posix_acl_* xattrs, all users should get
    permission to be able to read glusterfs.posix.acl* xattrs too.
    
    Change-Id: I1fc2b67c8a12113910e4ec57cd114e4baefe0d38
    BUG: 1459971
    Signed-off-by: Soumya Koduri <skoduri>
    Reviewed-on: https://review.gluster.org/17493
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: jiffin tony Thottan <jthottan>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Raghavendra Talur <rtalur>
    Reviewed-by: Niels de Vos <ndevos>

Comment 1 Worker Ant 2017-06-12 10:45:11 UTC
REVIEW: https://review.gluster.org/17513 (posix-acl: Whitelist virtual ACL xattrs) posted (#1) for review on release-3.10 by soumya k (skoduri)

Comment 2 Worker Ant 2017-06-20 04:56:47 UTC
COMMIT: https://review.gluster.org/17513 committed in release-3.10 by Raghavendra Talur (rtalur) 
------
commit ef331f945bfd4e5664d557ce8e5a4bd275792e13
Author: Soumya Koduri <skoduri>
Date:   Thu Jun 8 22:19:17 2017 +0530

    posix-acl: Whitelist virtual ACL xattrs
    
    Similar to system.posix_acl_* xattrs, all users should get
    permission to be able to read glusterfs.posix.acl* xattrs too.
    
    This is backport of below mainline patch -
    https://review.gluster.org/17493
    
    >BUG: 1459971
    >Signed-off-by: Soumya Koduri <skoduri>
    >Reviewed-on: https://review.gluster.org/17493
    >Smoke: Gluster Build System <jenkins.org>
    >Reviewed-by: jiffin tony Thottan <jthottan>
    >NetBSD-regression: NetBSD Build System <jenkins.org>
    >CentOS-regression: Gluster Build System <jenkins.org>
    >Reviewed-by: Raghavendra Talur <rtalur>
    >Reviewed-by: Niels de Vos <ndevos>
    >(cherry picked from commit 68f2192df570b5ee615d440c2e0c88d49a75a34f)
    
    BUG: 1460649
    Change-Id: I1fc2b67c8a12113910e4ec57cd114e4baefe0d38
    Signed-off-by: Soumya Koduri <skoduri>
    Reviewed-on: https://review.gluster.org/17513
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Raghavendra Talur <rtalur>

Comment 3 Shyamsundar 2018-06-20 18:29:33 UTC
This bug reported is against a version of Gluster that is no longer maintained
(or has been EOL'd). See https://www.gluster.org/release-schedule/ for the
versions currently maintained.

As a result this bug is being closed.

If the bug persists on a maintained version of gluster or against the mainline
gluster repository, request that it be reopened and the Version field be marked
appropriately.


Note You need to log in before you can comment on or make changes to this bug.