Bug 1460659 - Avoid one extra call of l(get|list)xattr system call after use buffer in posix_getxattr
Summary: Avoid one extra call of l(get|list)xattr system call after use buffer in posi...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: posix
Version: mainline
Hardware: x86_64
OS: Linux
low
low
Target Milestone: ---
Assignee: Mohit Agrawal
QA Contact:
URL:
Whiteboard:
Depends On: 1460658
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-06-12 10:59 UTC by Mohit Agrawal
Modified: 2017-09-05 17:34 UTC (History)
4 users (show)

Fixed In Version: glusterfs-3.12.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1460658
Environment:
Last Closed: 2017-09-05 17:34:18 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Comment 1 Worker Ant 2017-06-12 11:34:53 UTC
REVIEW: https://review.gluster.org/17520 (posix: Avoid one extra call of l(get|list)xattr call after use buffer in posix_getxattr) posted (#1) for review on master by MOHIT AGRAWAL (moagrawa)

Comment 2 Worker Ant 2017-07-03 11:08:05 UTC
COMMIT: https://review.gluster.org/17520 committed in master by Jeff Darcy (jeff.us) 
------
commit 89faa4661d1ef66a9f8fe3b79e26bf4505ab6c61
Author: Mohit Agrawal <moagrawa>
Date:   Mon Jun 12 16:30:20 2017 +0530

    posix: Avoid one extra call of l(get|list)xattr call after use buffer in posix_getxattr
    
    Problem: In posix xlator posix_(f)getxattr is calling system call(sys_lgetxattr)
             two times to fetch the xattr value.
    
    Solution: After use the extra buffer for first time calling we can avoid second
              attempt of system call(sys_lgetxattr) calling in posix_getxattr for most
              of the xattrs.
    
    BUG: 1460659
    Change-Id: I0d8da776c5bc86653d874a4629a73bbf65c621b8
    Signed-off-by: Mohit Agrawal <moagrawa>
    Reviewed-on: https://review.gluster.org/17520
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Amar Tumballi <amarts>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Kinglong Mee

Comment 3 Shyamsundar 2017-09-05 17:34:18 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.12.0, please open a new bug report.

glusterfs-3.12.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-September/000082.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.