Bug 1460787 - Container Review Request - docker - the docker daemon as a system container
Summary: Container Review Request - docker - the docker daemon as a system container
Keywords:
Status: NEW
Alias: None
Product: Fedora Container Images
Classification: Fedora
Component: Container Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-06-12 18:30 UTC by Yu Qi Zhang
Modified: 2017-06-13 15:50 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:
jbrooks: fedora-review+


Attachments (Terms of Use)

Description Yu Qi Zhang 2017-06-12 18:30:11 UTC
Container Build Info URL: https://github.com/projectatomic/atomic-system-containers/tree/master/docker-fedora

Description: This is the docker daemon (https://github.com/moby/moby) in a system container. This is effectively a duplicate of the container-engine system container that current lives in the fedora registry. If this container image passes review, the container-engine system container will take advantage of FLIBS and will just be another layer on top of this image.

There are 2 reasons for this:

1. The container-engine system container was designed to be an abstract daemon meant to potentially provide multiple runtimes in the future. As such it makes more sense to abstract out the container-engine system container.

2. The container image should match the name of the package it provides (in this case, docker). Although this image current only provides the docker daemon, there are plans to provide the client as well, so it makes sense to use the rpm name.

Fedora Account System Username: yzhang

Comment 1 Jason Brooks 2017-06-12 21:10:31 UTC
I reviewed this pkg under the container-engine name that yzhang refers to at https://bugzilla.redhat.com/show_bug.cgi?id=1452221. This is the same package source, I approve.

Comment 2 Gwyn Ciesla 2017-06-13 15:50:19 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/container/docker


Note You need to log in before you can comment on or make changes to this bug.