Bug 1460787 - Container Review Request - docker - the docker daemon as a system container
Container Review Request - docker - the docker daemon as a system container
Status: NEW
Product: Fedora Container Images
Classification: Fedora
Component: Container Review (Show other bugs)
rawhide
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-06-12 14:30 EDT by Yu Qi Zhang
Modified: 2017-06-13 11:50 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
jbrooks: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Yu Qi Zhang 2017-06-12 14:30:11 EDT
Container Build Info URL: https://github.com/projectatomic/atomic-system-containers/tree/master/docker-fedora

Description: This is the docker daemon (https://github.com/moby/moby) in a system container. This is effectively a duplicate of the container-engine system container that current lives in the fedora registry. If this container image passes review, the container-engine system container will take advantage of FLIBS and will just be another layer on top of this image.

There are 2 reasons for this:

1. The container-engine system container was designed to be an abstract daemon meant to potentially provide multiple runtimes in the future. As such it makes more sense to abstract out the container-engine system container.

2. The container image should match the name of the package it provides (in this case, docker). Although this image current only provides the docker daemon, there are plans to provide the client as well, so it makes sense to use the rpm name.

Fedora Account System Username: yzhang
Comment 1 Jason Brooks 2017-06-12 17:10:31 EDT
I reviewed this pkg under the container-engine name that yzhang refers to at https://bugzilla.redhat.com/show_bug.cgi?id=1452221. This is the same package source, I approve.
Comment 2 Gwyn Ciesla 2017-06-13 11:50:19 EDT
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/container/docker

Note You need to log in before you can comment on or make changes to this bug.