Bug 1460815 - Formatting of Provider summary PDF file generated from provider summary page is very broken
Summary: Formatting of Provider summary PDF file generated from provider summary page ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.7.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: GA
: 5.8.3
Assignee: Eric Winchell
QA Contact: Jan Krocil
URL:
Whiteboard:
Depends On: 1447940
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-06-12 20:40 UTC by Satoe Imaishi
Modified: 2022-07-09 09:07 UTC (History)
5 users (show)

Fixed In Version: 5.8.3.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1447940
Environment:
Last Closed: 2018-02-28 13:04:21 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2018:0374 0 normal SHIPPED_LIVE Important: Red Hat CloudForms security, bug fix, and enhancement update 2018-02-28 18:04:37 UTC

Comment 2 CFME Bot 2017-06-16 13:03:51 UTC
New commit detected on ManageIQ/manageiq-ui-classic/fine:
https://github.com/ManageIQ/manageiq-ui-classic/commit/05b8cd191aaceb294a808d908f10c2bc62d153fd

commit 05b8cd191aaceb294a808d908f10c2bc62d153fd
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu May 11 15:59:39 2017 -0400
Commit:     Satoe Imaishi <simaishi>
CommitDate: Fri Jun 16 09:01:25 2017 -0400

    Merge pull request #1332 from hayesr/fix_pdf_stylesheet_ext
    
    Fix missing stylesheet extension
    (cherry picked from commit 6d21b2eca5efd704e0da9ede5455eb2779972ecc)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1460815

 app/controllers/application_controller/report_downloads.rb | 2 +-
 spec/controllers/ems_common_controller_spec.rb             | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

Comment 3 CFME Bot 2017-06-16 13:06:07 UTC
New commit detected on ManageIQ/manageiq/fine:
https://github.com/ManageIQ/manageiq/commit/de2aeb5d0338a866e6ad3a41ee2ba2e3b5df2d32

commit de2aeb5d0338a866e6ad3a41ee2ba2e3b5df2d32
Author:     Oleg Barenboim <chessbyte>
AuthorDate: Thu Jun 1 22:59:31 2017 -0400
Commit:     Satoe Imaishi <simaishi>
CommitDate: Fri Jun 16 08:59:34 2017 -0400

    Merge pull request #15131 from hayesr/compiled_pdf_css
    
    Compile and write stylesheets for PDF rendering
    (cherry picked from commit cdbd852ffea53cd46bc3f26f0b0c853d403273da)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1460815

 lib/asset_writer.rb                       | 33 +++++++++++++++++++++++++
 lib/pdf_generator.rb                      |  4 ++-
 lib/pdf_generator/prince_pdf_generator.rb | 11 ++++++++-
 spec/lib/pdf_generator_spec.rb            | 41 +++++++++++++++++++++++++++++++
 4 files changed, 87 insertions(+), 2 deletions(-)
 create mode 100644 lib/asset_writer.rb
 create mode 100644 spec/lib/pdf_generator_spec.rb

Comment 4 CFME Bot 2017-06-16 13:08:38 UTC
New commit detected on ManageIQ/manageiq-ui-classic/fine:
https://github.com/ManageIQ/manageiq-ui-classic/commit/0b19b05bf4aee4f132aeed2b6b355f372dfd80aa

commit 0b19b05bf4aee4f132aeed2b6b355f372dfd80aa
Author:     Dan Clarizio <dclarizi>
AuthorDate: Fri Jun 9 12:43:47 2017 -0700
Commit:     Satoe Imaishi <simaishi>
CommitDate: Fri Jun 16 09:02:50 2017 -0400

    Merge pull request #1363 from hayesr/compiled_pdf_css
    
    Base64 encode fonts and images for PDF rendering
    (cherry picked from commit 87ddd8fe860bcafac4aac6f638754636ecc88db1)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1460815

 app/assets/stylesheets/pdf/_fontawesome.scss.erb   | 10 +++++
 app/assets/stylesheets/pdf/_patternfly.scss.erb    | 10 +++++
 app/assets/stylesheets/pdf/_report.scss            | 25 +++++++++++
 app/assets/stylesheets/pdf/_summary.scss           | 48 ++++++++++++++++++++++
 app/assets/stylesheets/pdf_report.css              | 31 +++-----------
 app/assets/stylesheets/pdf_summary.css             | 46 +++------------------
 app/controllers/application_controller.rb          |  4 ++
 app/helpers/image_encode_helper.rb                 | 31 ++++++++++++++
 app/helpers/quadicon_helper.rb                     | 16 +++-----
 app/views/layouts/show_pdf.html.haml               |  2 +-
 app/views/shared/summary/_icon_or_image.html.haml  |  2 +-
 spec/helpers/quadicon_helper_spec.rb               |  2 +
 spec/lib/pdf_generator_spec.rb                     | 35 ----------------
 .../listnav/_availability_zone.html.haml_spec.rb   |  3 +-
 .../listnav/_cloud_network.html.haml_spec.rb       |  3 +-
 .../listnav/_cloud_subnet.html.haml_spec.rb        |  3 +-
 .../listnav/_cloud_tenant.html.haml_spec.rb        |  3 +-
 .../layouts/listnav/_ems_cloud.html.haml_spec.rb   |  3 +-
 .../layouts/listnav/_ems_cluster.html.haml_spec.rb |  3 +-
 .../listnav/_ems_container.html.haml_spec.rb       |  3 +-
 .../layouts/listnav/_ems_network.html.haml_spec.rb |  3 +-
 .../layouts/listnav/_flavor.html.haml_spec.rb      |  3 +-
 .../layouts/listnav/_floating_ip.html.haml_spec.rb |  3 +-
 .../listnav/_host_aggregate.html.haml_spec.rb      |  3 +-
 .../listnav/_load_balancer.html.haml_spec.rb       |  3 +-
 .../listnav/_network_port.html.haml_spec.rb        |  3 +-
 .../listnav/_network_router.html.haml_spec.rb      |  3 +-
 .../listnav/_orchestration_stack.html.haml_spec.rb |  3 +-
 .../listnav/_persistent_volume.html.haml_spec.rb   |  3 +-
 .../listnav/_security_group.html.haml_spec.rb      |  3 +-
 30 files changed, 183 insertions(+), 130 deletions(-)
 create mode 100644 app/assets/stylesheets/pdf/_fontawesome.scss.erb
 create mode 100644 app/assets/stylesheets/pdf/_patternfly.scss.erb
 create mode 100644 app/assets/stylesheets/pdf/_report.scss
 create mode 100644 app/assets/stylesheets/pdf/_summary.scss
 create mode 100644 app/helpers/image_encode_helper.rb
 delete mode 100644 spec/lib/pdf_generator_spec.rb

Comment 10 Jan Krocil 2018-01-16 07:46:13 UTC
Verified fixed in 5.8.3.1 - 5.8.3.1.20180115183240_323eabe.

The generated PDF is formatted correctly.

Comment 13 errata-xmlrpc 2018-02-28 13:04:21 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:0374


Note You need to log in before you can comment on or make changes to this bug.