Bug 1460895 - Upcall missing invalidations
Summary: Upcall missing invalidations
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: upcall
Version: 3.11
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Poornima G
QA Contact:
URL:
Whiteboard:
Depends On: 1458127
Blocks: 1298708
TreeView+ depends on / blocked
 
Reported: 2017-06-13 05:05 UTC by Poornima G
Modified: 2017-06-28 18:32 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.11.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1458127
Environment:
Last Closed: 2017-06-28 18:32:26 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Poornima G 2017-06-13 05:05:46 UTC
+++ This bug was initially created as a clone of Bug #1458127 +++

Description of problem:

In fops like rename, link, unlink etc, the parent dirrs' client access time was not being updated. And in fops like create, link, symlink etc. the new file/dirs' client access time was not updated.

Reproducer:

TEST $CLI volume set $V0 performance.nl-cache on
TEST $CLI volume set $V0 nl-cache-positive-entry on
TEST $CLI volume set $V0 nl-cache-timeout 2
TEST $CLI volume set $V0 features.cache-invalidation on
TEST $CLI volume set $V0 features.cache-invalidation-timeout 2
TEST $CLI volume set $V0 md-cache-timeout 20

TEST $CLI volume start $V0;
EXPECT 'Started' volinfo_field $V0 'Status';

TEST glusterfs --volfile-id=/$V0 --volfile-server=$H0 $M0
TEST glusterfs --volfile-id=/$V0 --volfile-server=$H0 $M1

TEST mkdir $M0/dir
TEST touch $M0/dir/xyz
sleep 4
TEST mv $M0/dir/xyz $M0/dir/xyz1
TEST ! ls $M0/dir/file1
TEST touch $M1/dir/file1
TEST ls $M0/dir/file1
TEST ls $M0/dir/file1


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2017-06-02 01:56:35 EDT ---

REVIEW: https://review.gluster.org/17450 (upcall: Update the access time in missing cases) posted (#1) for review on master by Poornima G (pgurusid)

--- Additional comment from Worker Ant on 2017-06-04 00:38:46 EDT ---

REVIEW: https://review.gluster.org/17450 (upcall: Update the access time in missing cases) posted (#2) for review on master by Poornima G (pgurusid)

--- Additional comment from Worker Ant on 2017-06-09 07:30:35 EDT ---

COMMIT: https://review.gluster.org/17450 committed in master by Niels de Vos (ndevos) 
------
commit 149db390fd89beee1e8a3d946d4224ba2a9b4711
Author: Poornima G <pgurusid>
Date:   Fri Jun 2 10:05:33 2017 +0530

    upcall: Update the access time in missing cases
    
    Issue: In fops like rename, link, unlink etc, the parent
    dirrs' client access time was not being updated. And in fops like
    create, link, symlink etc. the new file/dirs' client access time was
    not updated.
    
    Solution: Update the client access time for both parent and new entry.
    
    Change-Id: Id9f63583216ae857f6251dca15797ac66fa85430
    BUG: 1458127
    Signed-off-by: Poornima G <pgurusid>
    Reviewed-on: https://review.gluster.org/17450
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>

Comment 1 Worker Ant 2017-06-13 05:06:40 UTC
REVIEW: https://review.gluster.org/17526 (upcall: Update the access time in missing cases) posted (#1) for review on release-3.11 by Poornima G (pgurusid)

Comment 2 Worker Ant 2017-06-13 14:24:02 UTC
COMMIT: https://review.gluster.org/17526 committed in release-3.11 by Shyamsundar Ranganathan (srangana) 
------
commit a8afcbea56fdf51246c82590899e0853e83424fb
Author: Poornima G <pgurusid>
Date:   Fri Jun 2 10:05:33 2017 +0530

    upcall: Update the access time in missing cases
    
    Issue: In fops like rename, link, unlink etc, the parent
    dirrs' client access time was not being updated. And in fops like
    create, link, symlink etc. the new file/dirs' client access time was
    not updated.
    
    Solution: Update the client access time for both parent and new entry.
    
    > Reviewed-on: https://review.gluster.org/17450
    > Smoke: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Niels de Vos <ndevos>
    > (cherry picked from commit 149db390fd89beee1e8a3d946d4224ba2a9b4711)
    
    Change-Id: Id9f63583216ae857f6251dca15797ac66fa85430
    BUG: 1460895
    Signed-off-by: Poornima G <pgurusid>
    Reviewed-on: https://review.gluster.org/17526
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 3 Shyamsundar 2017-06-28 18:32:26 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.1, please open a new bug report.

glusterfs-3.11.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-June/000074.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.