Bug 1460920 - [blkdeviotune] Libvirt should refuse to set group name when no other options are set.
[blkdeviotune] Libvirt should refuse to set group name when no other options ...
Status: ASSIGNED
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt (Show other bugs)
7.4
x86_64 Linux
medium Severity medium
: rc
: ---
Assigned To: Peter Krempa
jiyan
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-06-13 03:25 EDT by Fangge Jin
Modified: 2017-09-14 23:40 EDT (History)
6 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Fangge Jin 2017-06-13 03:25:53 EDT
Description of problem:
Set group name by blkdeviotune when on other options are set, the group name is set in domain xml, but it doesn't take effect actually as seen from the query result of blkceviotune.

Version-Release number of selected component (if applicable):
libvirt-3.2.0-9.virtcov.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1.Start a guest with no blkdeviotune parameters

2.# virsh blkdeviotune rhel7.4 vda
total_bytes_sec: 0
read_bytes_sec : 0
write_bytes_sec: 0
total_iops_sec : 0
read_iops_sec  : 0
write_iops_sec : 0
total_bytes_sec_max: 0
read_bytes_sec_max: 0
write_bytes_sec_max: 0
total_iops_sec_max: 0
read_iops_sec_max: 0
write_iops_sec_max: 0
size_iops_sec  : 0
group_name     :
total_bytes_sec_max_length: 0
read_bytes_sec_max_length: 0
write_bytes_sec_max_length: 0
total_iops_sec_max_length: 0
read_iops_sec_max_length: 0
write_iops_sec_max_length: 0

3.# virsh blkdeviotune rhel7.4 vda --group-name test

4.# virsh blkdeviotune rhel7.4 vda
total_bytes_sec: 0
read_bytes_sec : 0
write_bytes_sec: 0
total_iops_sec : 0
read_iops_sec  : 0
write_iops_sec : 0
total_bytes_sec_max: 0
read_bytes_sec_max: 0
write_bytes_sec_max: 0
total_iops_sec_max: 0
read_iops_sec_max: 0
write_iops_sec_max: 0
size_iops_sec  : 0
group_name     :              ==> group name is not set
total_bytes_sec_max_length: 0
read_bytes_sec_max_length: 0
write_bytes_sec_max_length: 0
total_iops_sec_max_length: 0
read_iops_sec_max_length: 0
write_iops_sec_max_length: 0

5.# virsh dumpxml rhel7.4|grep group -a1
      <iotune>
        <group_name>test</group_name>   ==> group name is set in domain xml
      </iotune>

6. 
# virsh blkdeviotune rhel7.4 vda --total-iops-sec 1000000000000000

7.
# virsh blkdeviotune rhel7.4 vda 
total_bytes_sec: 0
read_bytes_sec : 0
write_bytes_sec: 0
total_iops_sec : 1000000000000000
read_iops_sec  : 0
write_iops_sec : 0
total_bytes_sec_max: 0
read_bytes_sec_max: 0
write_bytes_sec_max: 0
total_iops_sec_max: 100000000000000
read_iops_sec_max: 0
write_iops_sec_max: 0
size_iops_sec  : 0
group_name     : drive-virtio-disk0  ===> the default value is used.
total_bytes_sec_max_length: 0
read_bytes_sec_max_length: 0
write_bytes_sec_max_length: 0
total_iops_sec_max_length: 1
read_iops_sec_max_length: 0
write_iops_sec_max_length: 0

8.But in guest dumpxml, group name is "test":
# virsh dumpxml rhel7.4|grep group
        <group_name>test</group_name>

Actual results:
As description

Expected results:
Refuse to set group name when no other options are set.

Note You need to log in before you can comment on or make changes to this bug.