Hide Forgot
+++ This bug was initially created as a clone of Bug #1444778 +++ F_OFD_* locking API is superior to posix locks and flock(1), we need it in RHEL to support applications doing proper file locking. The problem with posix locks are described in https://lwn.net/Articles/586904/ The disadvantage with flock(1) is it doesn't reliably work in certain cases like NFS (where it is translated to posix locks). As a concrete requirement, QEMU wants to use OFD locks to protect image files it opens, so that no concurrent writtings from different processes can happen, which would corrupt a qcow2 image, as an example. --- Additional comment from Jeff Layton on 2017-04-24 18:48:27 BRT --- It's certainly doable to add it, and I don't think it'd be problematic for kABI. Note that we'd also need to coordinate this with the companion glibc patches as well. --- Additional comment from Eric Sandeen on 2017-04-24 18:55:13 BRT --- I'm not sure that glibc can add new syscalls to a RHEL release w/o ABI problems - we ran into that back in the fallocate days ... --- Additional comment from Jeff Layton on 2017-04-24 19:01:52 BRT --- We don't need a new syscall here. It's just a matter of adding the F_OFD_* constants to the headers (and updating the docs if we care about that). If the kernel doesn't recognize the F_OFD_* commands, then it will just return -EINVAL. QEMU or whatever will need to be able to detect that as well.
We are currently in the practice of adding new constants to header files to enable kernel functionality, and this is just such a request, so we shouldn't have any real problem adding this to rhel-7.5. The upstream commit is here: commit 0961f7e1e300ef633b0c1ad95d0999fb5c169f4e Author: Jeff Layton <jlayton@poochiereds.net> Date: Wed Jul 23 14:21:05 2014 -0400 fcntl-linux.h: add new definitions and manual updates for open file description locks Open file description locks have been merged into the Linux kernel for v3.15. Add the appropriate command-value definitions and an update to the manual that describes their usage.
One concern is that the upstream API for this is still somewhat inconsistent (see swbz#20251). On the other hand, what is currently upstream is probably better than no support at all.
Interesting, I hadn't seen that swbz before. That's something that we should fix upstream. The original idea was to make these unavailable without large file offsets, IIRC. I'm fine with making such programs fail to compile. Maybe the F_OFD_* constants should be inside a #ifdef __USE_LARGEFILE64 condition?
I verified the provided example ofdlocks.c doesn't compile for the version glibc-2.17-238.el7 because of error: ‘F_OFD_SETLKW’ undeclared and error: ‘F_OFD_SETLK’ undeclared and compiles (with -D_FILE_OFFSET_BITS=64) and executes for the version glibc-2.17-239.el7. https://beaker.engineering.redhat.com/jobs/2757497 https://beaker.engineering.redhat.com/jobs/2758482
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2018:3092