RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

+++ This bug was initially created as a clone of Bug #1460640 +++

original subject of bug 1460640:
  virbr0 configured to be in "trusted" zone is not put in trusted zone at boot


Summary:


when NM notices that somebody else configures an interface, NM creates an in-memory connection with the intent not to manage/touch it (we call this: "external").

when the user subsequently modifies the generated connection, we shall take over the interface and start managing it.

In logfile rh1460640/f26.log from https://bugzilla.redhat.com/show_bug.cgi?id=1460640#c5 you can see that this doesn't work.


Fix it.

please review th/device-reapply-external-rh1462223

> device: refactor check_and_reapply_connection() to move device state check

+       if (priv->state != NM_DEVICE_STATE_ACTIVATED) {
+               g_set_error_literal (&local,
+                                    NM_DEVICE_ERROR,
+                                    NM_DEVICE_ERROR_NOT_ACTIVE,
+                                    "Device is not activated");
+               g_dbus_method_invocation_take_error (context, local);
+               return;
+       }

Please add audit logging.

The rest LGTM.

The new branch looks good.

merged upstream:

master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=f71195b102800f0268a172834de4ff3839cee734

nm-1-8: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=b54a4cb0d693a13381568d686d4767e7bbc94cbe

post-merge review, lgtm

all tests running in CI on all arches

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0778