RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1462660 - cockpit logical volume resize fails with error message
Summary: cockpit logical volume resize fails with error message
Keywords:
Status: CLOSED DUPLICATE of bug 1464953
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: cockpit
Version: 7.4
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Dominik Perpeet
QA Contact: qe-baseos-daemons
URL:
Whiteboard:
Depends On:
Blocks: 1459279
TreeView+ depends on / blocked
 
Reported: 2017-06-19 08:13 UTC by Dominik Perpeet
Modified: 2017-06-28 16:22 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-06-28 08:29:35 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
Screenshot of error from tests (102.52 KB, image/png)
2017-06-19 08:13 UTC, Dominik Perpeet 		no flags Details
View All

Description Dominik Perpeet 2017-06-19 08:13:32 UTC 
Created attachment 1289046 [details]
Screenshot of error from tests

Description of problem:
During Cockpit upstream integration testing, a test to resize a logical volume fails unexpectedly.

First found in https://fedorapeople.org/groups/cockpit/logs/pull-6360-20170615-152828-dd09a8ca-verify-rhel-7-4/log.html

Version-Release number of selected component (if applicable):
Cockpit 142.x

storaged:
Arch        : x86_64
Version     : 2.5.2
Release     : 3.el

How reproducible:
Always

Steps to Reproduce:
Run integration tests for volume resize https://github.com/cockpit-project/cockpit/blob/0177950a4be3abaff3545a92f62e094956b2caa3/test/verify/check-storage-resize#L57

Actual results:
Error message, see screenshot. Trace in issue: https://github.com/cockpit-project/cockpit/issues/6960
Comment 2 Marius Vollmer 2017-06-19 12:18:17 UTC 
This is caused by this change in lvm2 / fsadm:

https://sourceware.org/git/?p=lvm2.git;a=commit;h=1fe4f80e45a6bfcceed5aaab97fc0e27dfcf2b88

This change might break usage from scripts in general, as it did for Cockpit.
Comment 3 Zdenek Kabelac 2017-06-22 18:44:12 UTC 
lvm2 fixed long-term bug.

We cannot let 'script' running automatically in '--yes' mode.
Such option must be always given on command line and is also logged in metadata archive for analysis in case things went wrong somewhere.

So if  lvm2 users do want to apply --yes automatically - such option needs to be passed in.

i.e.  'lvresize --yes....'


This BZ is essentially duplicate of bug 1462696 - where we have resolved this 'yes' issue for both 'lvresize' and 'fsadm'.

*** This bug has been marked as a duplicate of bug 1462696 ***
Comment 4 Marius Vollmer 2017-06-26 08:53:00 UTC 
This is not a duplicate of bug 1462696.

This bug is about changing the default behavior of fsadm (nd indirectly lvresize): When stdin is connected to /dev/null, it used to unmount the filesystem if needed, now it fails.

To resolve this bug, we would need to either revert the default behavior of fsadm back to the old one, or decide that the new default behavior is correct and then close this bug as NOTABUG.

Closing this bug as NOTABUG means accepting that all uses of lvresize and fsadm need to be reviewed and possibly changed to pass "--yes".


Bug 1462696 is about the implementation of the new default behavior being broken.
Comment 5 Zdenek Kabelac 2017-06-26 09:32:56 UTC 
It's been bug and inconsistency in fsadm letting it work in '--yes' mode without terminal without specifying --yes on command line - causing seriously ill behavior as unconfirmed actions may have destabilize user's system.

Lvm2 does not support/handle backward compatibility for bugs - such bug should have been reported immediately and not been abused. Writing software on top of buggy logic will simply stop working the day the bug is fixed.

There is no 'new default' as mentioned in a comment 4. There is always only one consistent default behavior in lvm2 tools.

With terminal by default - prompt waits for answer.
With no terminal - answer 'N' is selected  (...was a bug in fsadm doing Y)
If user gives '--yes'  -  automatically answer 'Y'

If any software using lvm2 tools wants '--yes' answering for prompts it specifies '--yes' - it works this way for last decade.

There is no plan to reintroduce such bug back to lvm2.

If Cocpit needs '--yes' answering  'fsadm' and cannot simply add passing --yes - it maybe can switch to calling a 'wrapper' script  i.e.   'fsadm_yes' which will exec  system's fsadm and will add --yes argument this way.  Eventually create it's own hidden 'fsadm' in private binary PATH which will be found and  called instead of system's version of fsadm


As Lvm2 can't do any more here - passing this BZ to cocpit for more fixes.
Comment 7 Marius Vollmer 2017-06-28 08:29:35 UTC 
Story continues in bug 1464953

*** This bug has been marked as a duplicate of bug 1464953 ***
Note You need to log in before you can comment on or make changes to this bug.