Bug 1462682 - Review Request: libdazzle - Experimental new features for GTK+ and GLib
Review Request: libdazzle - Experimental new features for GTK+ and GLib
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Kalev Lember
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2017-06-19 05:21 EDT by Yanko Kaneti
Modified: 2017-06-22 07:52 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2017-06-22 07:52:11 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
klember: fedora‑review+

Attachments (Terms of Use)

  None (edit)
Description Yanko Kaneti 2017-06-19 05:21:47 EDT
Spec URL: http://declera.com/~yaneti/libdazzle/libdazzle.spec
SRPM URL: http://declera.com/~yaneti/libdazzle/libdazzle-3.25.3-1.fc27.src.rpm
Description: libdazzle is a collection of fancy features for GLib and Gtk+ that aren't quite ready or generic enough for use inside those libraries. This is often a proving ground for new widget prototypes. Applications such as Builder tend to drive development of this project.
Fedora Account System Username: yaneti
Comment 1 Kalev Lember 2017-06-22 04:10:35 EDT
Taking for review.
Comment 2 Kalev Lember 2017-06-22 04:23:43 EDT
Fedora review libdazzle-3.25.3-1.fc27.src.rpm 2017-06-22

$ rpmlint libdazzle-3.25.3-1.fc27.src.rpm \
          libdazzle \
          libdazzle-debuginfo \
libdazzle.x86_64: W: no-manual-page-for-binary dazzle-list-counters
libdazzle-devel.x86_64: W: only-non-binary-in-usr-lib
4 packages and 0 specfiles checked; 0 errors, 2 warnings.

+ OK
! needs attention

+ rpmlint warnings are harmless and can be ignored
+ The package is named according to Fedora packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The license text (COPYING) is included in %license
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match the sources in the srpm
  6fc3f7d6ec2aaa57f2500004c9763b0ec432f5269f5f74cc91a3da52d7bc6cf809893be6c0176495ffe309647af4efd1a22243bbd5b265846c301ce1d9d98d47  libdazzle-3.25.3.tar.xz
  6fc3f7d6ec2aaa57f2500004c9763b0ec432f5269f5f74cc91a3da52d7bc6cf809893be6c0176495ffe309647af4efd1a22243bbd5b265846c301ce1d9d98d47  Download/libdazzle-3.25.3.tar.xz
! A rawhide scratch build failed, https://koji.fedoraproject.org/koji/taskinfo?taskID=20091619 -- looks like an error building docs. It builds fine on f26 though. Possibly caused by something that has changed on rawhide?
n/a ExcludeArch bugs filed
+ BuildRequires look sane
+ locale handling
+ ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all the directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect the runtime of application
n/a Static libraries should be in -static
+ Development files should be in -devel
+ -devel must require the fully versioned base
+ Packages should not contain libtool .la files
n/a Proper .desktop file handling
+ Doesn't own files or directories already owned by other packages
+ Filenames are valid UTF-8

Looks nice and clean. APPROVED
Comment 3 Gwyn Ciesla 2017-06-22 07:08:31 EDT
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/libdazzle
Comment 4 Yanko Kaneti 2017-06-22 07:14:07 EDT
The reason it fails on rawhide is meson-0.40.1 vs meson-0.41.1
Haven't chased the details yet..
Comment 5 Yanko Kaneti 2017-06-22 07:18:34 EDT
Looking at meson git upstream this is probably fixed somewhere after 0.41.1
I'll import but not build for now, and leave this bug open when a build happens.
Comment 6 Yanko Kaneti 2017-06-22 07:52:11 EDT
Build done with a temporary workaround in the spec.


Note You need to log in before you can comment on or make changes to this bug.