Bug 1462767 - Segmentation fault when querying iscsi session
Summary: Segmentation fault when querying iscsi session
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: iscsi-initiator-utils
Version: 28
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Chris Leech
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-06-19 13:34 UTC by Gris Ge
Modified: 2019-05-28 23:40 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-05-28 23:40:03 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Gris Ge 2017-06-19 13:34:01 UTC
Description of problem:
====
[fge@fedr open-iscsi]$ sudo iscsiadm -m session -P 3
iSCSI Transport Class version 2.0-870
version 6.2.0.874
Segmentation fault
====


Version-Release number of selected component (if applicable):
iscsi-initiator-utils-6.2.0.874-4.git86e8892.fc27.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Connect to a iSCSI session.
2. sudo iscsiadm -m session -P 3
3.

Actual results:
Segmentation fault

Expected results:
Print iscsi session information

Additional info:

Program received signal SIGSEGV, Segmentation fault.
session_info_print (info_level=<optimized out>, info=<optimized out>, do_show=0) at session_info.c:426
426                     session_info_print_tree(&list, "", flags, do_show,
(gdb) bt
#0  session_info_print (info_level=<optimized out>, info=<optimized out>, do_show=0) at session_info.c:426
#1  0x000055555555a46f in main (argc=5, argv=0x7fffffffe538) at iscsiadm.c:3716


The upstream (8acf1fcc8d4d03ef64aee73ea16b5cf325878c97) does not have this problem.

Comment 1 Jan Kurik 2017-08-15 08:44:07 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 27 development cycle.
Changing version to '27'.

Comment 2 Seth Howell 2017-10-30 20:13:46 UTC
This error also exists in fedora 26. 

Version-Release number of selected component (if applicable):
iscsiadm version 6.2.0.874
iscsi-initiator-utils-6.2.0.874-3.git86e8892.fc26.x86_64

root cause:
It occurs because between iscsiadm version 6.2.0.873-33 and version 6.2.0.874, a timeout argument was added to session_info_print_tree function, and the iscsi_req_tmo field of the session_info pointer provided to session_info_print is used to populate that argument. 
However, line 426 of session_info.c is on a branch that assumes that the session_info pointer passed to session_info_print is Null. That is why the call to session_info_print_tree on that line fails with a segfault.

Possible Solution:
In the upstream version of open-iscsi on Github, the call to session_info_print_tree on line 426 passes -1 as the timeout argument instead of using the value of info->iscsi_req_tmo. I also pulled the source rpm, and changed line 426 to read:
session_info_print_tree(&list, "", flags, do_show, -1);
Making that change to the fedora source fixed the issue for my use case.

Comment 3 ZhangQiuLiang 2018-07-20 07:29:07 UTC
This error is still exists in fedora 28.

while i run avocado to test about muti vms.
it use command iscsiadm.

$ sudo iscsiadm -m session -P 3
iSCSI Transport Class version 2.0-870
version 6.2.0.874
Segmentation fault

Comment 4 Ben Cotton 2019-05-02 19:54:41 UTC
This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Ben Cotton 2019-05-28 23:40:03 UTC
Fedora 28 changed to end-of-life (EOL) status on 2019-05-28. Fedora 28 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.