Bug 146291
| Summary: | GUI adds trailing spaces to "options" lines in /etc/modprobe.conf when adding/deleting wireless devices | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Jack Perdue <ss> |
| Component: | system-config-network | Assignee: | Harald Hoyer <harald> |
| Status: | CLOSED ERRATA | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | high | ||
| Version: | 5.1 | CC: | berryja, ddumas, jmoskovc, lftabera, mattdm, pknirsch |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | bzcl34nup | ||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
* the previous version adds trailing spaces to "options" lines in
/etc/modprobe.conf when adding or deleting wireless devices. These spaces would be added to lines not being otherwise affected by the addition or deletion of the wireless devices and the presence of these spaces was observed to cause a crash in certain hardware, including nVidia's accelerated kernel module. This updated package no longer adds these spaces to /etc/modprobe.conf.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-01-20 21:53:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 87718 | ||
|
Description
Jack Perdue
2005-01-26 18:57:45 UTC
I see the same thing in FC3 system-config-network-1.3.22-1. Also, to
recreate this problem, you need only start system-config-network and
click File->Save. I also seem to have a problem with the last line of
modprobe.conf being replicated on the save. The last line of
modprobe.conf for me is:
alias char-major-195* nvidia
After saving from system-config-network, this line appears twice at
the end. The extra spaces seem to be coming from
/usr/share/system-config-network/netconfpkg/NCHardwareList.py lines
100-106:
def joinoptlist(self, dict):
optstring = ''
for key in dict.keys():
if dict[key] != None:
optstring = optstring + key + '=' + dict[key] + ' '
else:
optstring = optstring + key + ' '
I don't know Python, but this code definitely adds a space to the end
of the optstring variable and the class that this is a part of seems
to have something to do with /etc/modprobe.conf as line 68 has:
filename = netconfpkg.ROOT + MODULESCONF
and NC_functions.py has:
MODULESCONF='/etc/modprobe.conf'
Here's a small little patch to fix the trailing spaces problem:
-- NCHardwareList.py.orig 2005-01-27 09:28:23.000000000 -0600
+++ NCHardwareList.py 2005-01-27 10:37:24.398738352 -0600
@@ -105,7 +105,7 @@
else:
optstring = optstring + key + ' '
- return optstring
+ return optstring.strip()
As for the duplicated last line... further experimentation
shows that it only duplicates aliases that have a "*" in it.
For example, if I have the following at the end of modprobe.conf:
alias char-major-195* nvidia
alias eth4 3c501
alias foo* bar
# LAST LINE
and then I start up system-config-network and do File->Save
twice, I get:
alias char-major-195* nvidia
alias eth4 3c501
alias foo* bar
# LAST LINE
alias char-major-195* nvidia
alias foo* bar
alias char-major-195* nvidia
alias foo* bar
I do not presently know how to correct this behavior
(not that it has caused a problem yet so long as you
can tolerate unnecessary garbage at the end).
For me the extra spaces at the end of options lines broke both nvidia loading and alsa sound card loading. The spaces were added to the following lines. options snd-intel8x0 index=0 id="ICH" options snd cards_limit=2 This would seem to be a but in module loading. Fedora Core 2 is now maintained by the Fedora Legacy project for security updates only. If this problem is a security issue, please reopen and reassign to the Fedora Legacy product. If it is not a security issue and hasn't been resolved in the current FC3 updates or in the FC4 test release, reopen and change the version to match. Still present in FC3/system-config-network-1.3.22-1 The same proble with FC4/system-config-network-1.3.26-1
My modprobe.conf is the following
########################################################
alias snd-card-0 snd-intel8x0
options snd-card-0 index=0
install snd-intel8x0 /sbin/modprobe --ignore-install snd-intel8x0 &&
/usr/sbin/alsactl restore >/dev/null 2>&1 || :
remove snd-intel8x0 { /usr/sbin/alsactl store >/dev/null 2>&1 || : ; };
/sbin/modprobe -r --ignore-remove snd-intel8x0
alias usb-controller ehci-hcd
alias usb-controller1 uhci-hcd
#options ipw2100 ifname=eth1
options i8k force=1
alias eth0 e100
###############################################
And I only detect this behaviour in the line
options i8k force=1
This also breaks the load of the module with an unknown symbol error message
Still happens on FC5 with system-config-network-1.3.30-2.1 Is there a problem with my: - return optstring + return optstring.strip() patch above for the trailing space problem? Based on the date this bug was created, it appears to have been reported against rawhide during the development of a Fedora release that is no longer maintained. In order to refocus our efforts as a project we are flagging all of the open bugs for releases which are no longer maintained. If this bug remains in NEEDINFO thirty (30) days from now, we will automatically close it. If you can reproduce this bug in a maintained Fedora version (7, 8, or rawhide), please change this bug to the respective version and change the status to ASSIGNED. (If you're unable to change the bug's version or status, add a comment to the bug and someone will change it for you.) Thanks for your help, and we apologize again that we haven't handled these issues to this point. The process we're following is outlined here: http://fedoraproject.org/wiki/BugZappers/F9CleanUp We will be following the process here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping to ensure this doesn't happen again. Both problems still exists with system-config-network-1.3.99-2.el5 on RHEL 5.1, which, AFAIK, is not EOL. This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. Release note added. If any revisions are required, please set the "requires_release_notes" flag to "?" and edit the "Release Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: * the previous version adds trailing spaces to "options" lines in /etc/modprobe.conf when adding or deleting wireless devices. These spaces would be added to lines not being otherwise affected by the addition or deletion of the wireless devices and the presence of these spaces was observed to cause a crash in certain hardware, including nVidia's accelerated kernel module. This updated package no longer adds these spaces to /etc/modprobe.conf. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2009-0193.html |