Bug 1463353 - Review Request: casync - Content Addressable Data Synchronizer
Summary: Review Request: casync - Content Addressable Data Synchronizer
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Igor Gnatenko
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1464479 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-06-20 15:34 UTC by Zbigniew Jędrzejewski-Szmek
Modified: 2017-07-23 09:04 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-07-23 09:04:29 UTC
Type: ---
Embargoed:
ignatenko: fedora-review+


Attachments (Terms of Use)

Description Zbigniew Jędrzejewski-Szmek 2017-06-20 15:34:07 UTC
Spec URL: https://in.waw.pl/~zbyszek/fedora/casync.spec
SRPM URL: https://in.waw.pl/~zbyszek/fedora/casync-1-1.fc27.src.rpm
Description:
casync provides a way to efficiently transfer files which change over
time over the internet. It will split a given set into a git-inspired
content-addressable set of smaller compressed chunks, which can then
be conveniently transferred using HTTP. On the receiving side those
chunks will be uncompressed and merged together to recreate the
original data. When the original data is modified, only the new chunks
have to be transferred during an update.

Fedora Account System Username: zbyszek
koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20071688

Comment 1 Igor Gnatenko 2017-06-20 15:39:55 UTC
* I think that %_prefix/lib/casync should be really %_libexecdir/casync...
* https://github.com/systemd/casync/archive/v1.tar.gz#/casync-%{version}.tar.gz -> https://github.com/systemd/casync/archive/v%{version}/%{name}-%{version}.tar.gz

No other issues found.

Comment 2 Zbigniew Jędrzejewski-Szmek 2017-06-20 15:52:35 UTC
(In reply to Igor Gnatenko from comment #1)
> * I think that %_prefix/lib/casync should be really %_libexecdir/casync...
That's really an upstream thing. I don't think it matters much, and I don't want to diverge from upstream.

> https://github.com/systemd/casync/archive/v1.tar.gz#/casync-%{version}.tar.
> gz ->
> https://github.com/systemd/casync/archive/v%{version}/%{name}-%{version}.tar.
> gz
Fixed.
 
Thank you for the review.

Comment 3 Gwyn Ciesla 2017-06-20 16:08:16 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/casync

Comment 4 Igor Gnatenko 2017-06-20 16:11:00 UTC
(In reply to Zbigniew Jędrzejewski-Szmek from comment #2)
> (In reply to Igor Gnatenko from comment #1)
> > * I think that %_prefix/lib/casync should be really %_libexecdir/casync...
> That's really an upstream thing. I don't think it matters much, and I don't
> want to diverge from upstream.

I meant that you should consider reporting this to upstream so next release it will be properly done. ;)

Comment 5 Michal Schmidt 2017-06-21 15:25:55 UTC
FHS documents both /usr/libexec/$PKG/ and /usr/lib/$PKG/ as acceptable.
https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s07.html

Lennart is known to dislike libexec.
https://lists.fedoraproject.org/pipermail/devel/2012-December/175518.html

Comment 6 James Hogarth 2017-06-23 14:14:09 UTC
*** Bug 1464479 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.