Bug 1463382 - take-over-existing-cluster.yml doesn't work at all in ceph-ansible-2.2.11-1
Summary: take-over-existing-cluster.yml doesn't work at all in ceph-ansible-2.2.11-1
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Ceph Storage
Classification: Red Hat Storage
Component: Ceph-Ansible
Version: 3.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: rc
: 3.0
Assignee: David Galloway
QA Contact: ceph-qe-bugs
URL:
Whiteboard:
Depends On:
Blocks: 1501117
TreeView+ depends on / blocked
 
Reported: 2017-06-20 17:33 UTC by David Galloway
Modified: 2022-02-21 18:03 UTC (History)
12 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1501117 (view as bug list)
Environment:
Last Closed: 2017-08-02 11:42:07 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github ceph ceph-ansible pull 1613 0 None closed Fixes to take-over-existing-cluster playbook 2020-07-14 12:47:42 UTC
Red Hat Issue Tracker RHCEPH-1523 0 None None None 2021-09-09 12:24:24 UTC

Description David Galloway 2017-06-20 17:33:23 UTC
Description of problem:
take-over-existing-cluster.yml fails due to a bug introduced in https://github.com/ceph/ceph-ansible/commit/4639d89231dc35c743ded29ed0f962f36a4b0574.

This task now basically stats the string of the cluster name and so the next task fails due to missing dict values: https://github.com/ceph/ceph-ansible/blob/4639d89231dc35c743ded29ed0f962f36a4b0574/infrastructure-playbooks/take-over-existing-cluster.yml#L35-L38

Version-Release number of selected component (if applicable):
ceph-ansible-2.2.11-1

How reproducible:
Every time

Steps to Reproduce:
1. Install ceph-ansible-2.2.11-1.el7scon.noarch
2. Follow downstream docs to take over an existing cluster

Actual results:
Playbook fails

Expected results:
Successful new ceph.conf creation

Additional info:
We also *really* should be making backups of the original ceph.conf IMO.  I'm working on this in a branch on upstream ceph-ansible.

Comment 2 David Galloway 2017-06-20 18:00:10 UTC
https://github.com/ceph/ceph-ansible/pull/1613 should fix this.

Comment 3 Christina Meno 2017-06-26 21:05:09 UTC
Thomas would you please tell us how you are tracking work to be released in the next 2.x async release? This is a candidate for that.

Comment 6 Federico Lucifredi 2017-08-02 11:42:07 UTC
Running take-over-existing-cluster is valid in 2.x as we changed from ceph-deploy (in 1.3) to ceph-ansible in 2.0 and had to provide a way for customer to make sure the existing cluster is brought under ceph-ansible control to handle management tasks like add/remove osds.

In 3.0, the assumption is that either cluster is installed newly or upgraded from 2.x. In both cases, take over use case is not applicable in 3.0.


Note You need to log in before you can comment on or make changes to this bug.