Bug 1464025 - pre_upgrade checking failed for upgrades/etcd/noop.yml does not exist
pre_upgrade checking failed for upgrades/etcd/noop.yml does not exist
Status: VERIFIED
Product: OpenShift Container Platform
Classification: Red Hat
Component: Upgrade (Show other bugs)
3.6.0
Unspecified Unspecified
unspecified Severity high
: ---
: 3.7.0
Assigned To: Russell Teague
liujia
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-06-22 06:09 EDT by Anping Li
Modified: 2017-09-18 02:56 EDT (History)
5 users (show)

See Also:
Fixed In Version: openshift-ansible-3.7.0-0.126.1.git.0.0bb5b0c.el7.noarch
Doc Type: Bug Fix
Doc Text:
When Ansible tags are used for evaluating some of the tasks in a set of playbooks, the conditional for including a task file was not properly evaluated. The logic modification allows the conditional to evaluate properly and skip running the task.
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Anping Li 2017-06-22 06:09:09 EDT
Description of problem:
When run upgrade with --tags pre_upgrade, it failed for "the file_name '/usr/share/ansible/openshift-ansible/playbooks/common/openshift-cluster/upgrades/etcd/noop.yml' does not exist, or is not readable"

Version-Release number of selected component (if applicable):
openshift-ansible-3.6.121

How reproducible:


Steps to Reproduce:
1. install OCP v3.5 with dedicated etcd clusters
2. prechecking upgrade 
   anible-playbook usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_6/upgrade.yml --tags pre_upgrade



Actual results:
PLAY [Upgrade to 2.1] **********************************************************

TASK [setup] *******************************************************************
ok: [openshift-225.lab.eng.nay.redhat.com]

TASK [etcd_common : Include main action task file] *****************************
fatal: [openshift-225.lab.eng.nay.redhat.com]: FAILED! => {
    "failed": true, 
    "reason": "the file_name '/usr/share/ansible/openshift-ansible/playbooks/common/openshift-cluster/upgrades/etcd/noop.yml' does not exist, or is not readable"
}
    to retry, use: --limit @/usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_6/upgrade.retry

PLAY RECAP *********************************************************************
localhost                  : ok=14   changed=0    unreachable=0    failed=0   
openshift-208.lab.eng.nay.redhat.com : ok=92   changed=2    unreachable=0    failed=0   
openshift-225.lab.eng.nay.redhat.com : ok=135  changed=2    unreachable=0    failed=1   

Error: ansible-playbook --private-key /root/configdir/libra.pem -i /root/workdir/hosts /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_6/upgrade.yml --tags pre_upgrade -v. logfile: logs-20170621090802-upgrade

Expected results:


Additional info:
Comment 1 Russell Teague 2017-06-22 15:07:56 EDT
Proposed: https://github.com/openshift/openshift-ansible/pull/4547
Comment 2 Scott Dodson 2017-06-26 09:46:52 EDT
Moving this to 3.6.1 as running with tags is not common.
Comment 3 Russell Teague 2017-08-16 16:39:36 EDT
PR updated with proposed fix.
Comment 4 Russell Teague 2017-08-17 07:58:48 EDT
Merged: https://github.com/openshift/openshift-ansible/pull/4547
Comment 5 liujia 2017-09-08 06:46:57 EDT
Version:
atomic-openshift-utils-3.7.0-0.125.0.git.0.91043b6.el7.noarch

Steps:
1. Install 3.6 cluster with dedicated etcd.
2. Pre-check upgrade 
# ansible-playbook -i hosts /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_7/upgrade.yml --tags pre_upgrade

Pre-upgrade still failed.
TASK [etcd_common : Include main action task file] **************************************************************************************************************************
task path: /usr/share/ansible/openshift-ansible/roles/etcd_common/tasks/main.yml:7
fatal: [openshift-178.x.x.x]: FAILED! => {
    "failed": true, 
    "reason": "the file_name '/usr/share/ansible/openshift-ansible/playbooks/common/openshift-cluster/upgrades/etcd/noop.yml' does not exist, or is not readable"
}
Comment 6 Russell Teague 2017-09-08 15:26:39 EDT
Proposed: https://github.com/openshift/openshift-ansible/pull/5338

Side note:
The usage of tags to run `pre_upgrade` does not produce an acceptable user experience due to the many skipped tasks.  The upgrade playbooks will be refactored to allow an entry point to just run upgrade checks if they are desired.  The use of tags as a whole in openshift-ansible will eventually be deprecated.
Comment 7 Russell Teague 2017-09-11 08:44:06 EDT
Merged: https://github.com/openshift/openshift-ansible/pull/5338
Comment 8 liujia 2017-09-14 05:43:20 EDT
Bug verification blocked by bug 1451023.
Comment 9 liujia 2017-09-18 02:56:54 EDT
Version:
atomic-openshift-utils-3.7.0-0.126.4.git.0.3fc2b9b.el7.noarch

Steps:
1. Install 3.6 cluster with dedicated etcd.
2. Pre-check upgrade 
# ansible-playbook -i hosts /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_7/upgrade.yml --tags pre_upgrade

Pre_check succeed.

Note You need to log in before you can comment on or make changes to this bug.