Red Hat Bugzilla – Bug 1464329
Container Review Request - waiverdb - Service for waiving results in ResultsDB
Last modified: 2017-07-07 00:00:55 EDT
Container Build Info URL: https://fedorapeople.org/~dcallagh/containers/waiverdb/
Description: WaiverDB is a companion service to ResultsDB, for recording waivers against test results.
Fedora Account System Username: dcallagh
Some issues based on the guidelines: https://fedoraproject.org/wiki/Container:Guidelines#Container_Guidelines
- The labels need to be first defined as ENV variables and then used in the LABELS in a second line. The name needs to be prefixed with $FGC.
- The help file needs to be called README.md or help.1 (not help.md).
- The help file needs to be copied into the container at build time.
Can you fix those up and I can take another look?
(In reply to Ralph Bean from comment #1)
> Some issues based on the guidelines:
> - The labels need to be first defined as ENV variables and then used in the
> LABELS in a second line. The name needs to be prefixed with $FGC.
Hmm yeah when I looked at the guidelines that was optional, and since nothing in the container itself would ever refer to those environment variables I figured it wasn't necessary.
But you are right, it seems mandatory now :-)
I am still unclear as to *why*, but I haven't seen the container build service in action yet so I'll just assume it is needed for that.
> - The help file needs to be called README.md or help.1 (not help.md).
> - The help file needs to be copied into the container at build time.
Same here... I was reading the container guidelines in conjunction with a thread on an internal mailing list where there was some conflicting advice offered about this... I had thought that help.md would be magically transformed into help.1 *and* copied into the container for me by the build service. But you are right, the container guidelines don't support that assumption.
> Can you fix those up and I can take another look?
Will do! Updated version to come shortly.
Second attempt: https://fedorapeople.org/~dcallagh/containers/waiverdb-attempt2/
* renamed help.md to README.md and COPY'd it into the root of the container image
* updated ENV and LABEL declarations as per the example in the guidelines (except I left out the arch since WaiverDB is in Python and should work on all arches)
(There actually *is* a README.md file in that directory, but it's not shown in the directory listing for some reason... probably because Apache is interpreting it as a directory README or something???)
Thanks. Looks good to me. :)
This container image is now built! For rawhide, f26, and f25.
$ sudo docker pull candidate-registry.fedoraproject.org/f25/waiverdb:latest
It's still living on candidate-registry.fedoraproject.org, I'm not sure if/how it gets promoted to registry.fedoraproject.org since I guess Bodhi doesn't know about container images... but that is something to figure out later.