Bug 1464355 - Starting varnishncsa during boot fails
Starting varnishncsa during boot fails
Status: ASSIGNED
Product: Fedora EPEL
Classification: Fedora
Component: varnish (Show other bugs)
epel7
x86_64 Linux
unspecified Severity medium
: ---
: ---
Assigned To: Ingvar Hagelund
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-06-23 04:28 EDT by Gerald Vogt
Modified: 2017-06-26 03:19 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Gerald Vogt 2017-06-23 04:28:33 EDT
Description of problem:

We have a server which is running varnishd and varnishncsa for logging. However, during boot varnishncsa fails because varnishd isn't ready, yet.


Version-Release number of selected component (if applicable):

varnish-4.0.4-3.el7.x86_64

How reproducible:

Install varnish, enable varnishncsa with systemctl and reboot


Steps to Reproduce:
1. Install varnish and configure it.
2. systemctl enable varnishncsa
3. reboot

Actual results:

varnishncsa fails during boot.

Expected results:

varnishncsa is running

Additional info:

Logs show the problem:

Jun 22 08:22:04 test systemd: Failed to read PID from file /var/run/varnish.pid: Invalid argument
Jun 22 08:22:04 test systemd: Started Varnish Cache, a high-performance HTTP accelerator.
Jun 22 08:22:04 test systemd: Starting Varnish Cache HTTP accelerator NCSA logging daemon...
zun 22 08:22:04 test varnishd[936]: Platform: Linux,3.10.0-514.21.2.el7.x86_64,x86_64,-sfile,-smalloc,-hcritbit
Jun 22 08:22:04 test systemd: varnishncsa.service: control process exited, code=exited status=1
Jun 22 08:22:04 test systemd: Failed to start Varnish Cache HTTP accelerator NCSA logging daemon. 
Jun 22 08:22:04 test systemd: Unit varnishncsa.service entered failed state.
Jun 22 08:22:04 test systemd: varnishncsa.service failed. 
Jun 22 08:22:05 test varnishd[936]: child (939) Started 
Jun 22 08:22:05 test varnishd[936]: Child (939) said Child starts
Jun 22 08:22:05 test varnishd[936]: Child (939) said SMF.s0 mmap'ed 2147483648 bytes of 2147483648

So it seems to me varnishncsa is started while varnishd is still starting up. Thus, either varnishncsa has to wait or the varnishd start during boot should only return once varnishd is up...
Comment 1 Ingvar Hagelund 2017-06-26 03:11:12 EDT
The problem here is that varnishncsa starts too fast, that is, before varnishd has gotten around to open its vsm file. A simple workaround could be just to add a pause to the startup of varnishd like "ExecStartPost=sleep 5" in varnish.service, or just make varnishncsa try restarting until it succeeds, that is "Restart=on-failure" in varnishncsa.service.

A more correct solution would be to figure out some systemd probe-able resource that is not available before varnishd has started proberly, and make varnishncsa wait for that. I've got to look more into this, and ask upstream.

Ingvar
Comment 2 Ingvar Hagelund 2017-06-26 03:19:39 EDT
Upstream issue: https://github.com/varnishcache/pkg-varnish-cache/issues/79

Note You need to log in before you can comment on or make changes to this bug.