Bug 1464571

Devs, after discussion with stakeholders, I'm going to propose we do this instead: when the release command is run, detect this scenario, and emit an error informing them that we don't support the scenario (i.e. in this scenario both `release --list` and `release --set` should fail).

This shouldn't cause a real problem with the scenario described in comment 0, because a) the scenario is an invalid one, and b) on a functional level, the behavior will be that you wouldn't be able to use release --set, which is the effect of comment 0.

Preliminary verification of  the fix :
======================================

subscription-manager: 1.20.2-1.el7
python-rhsm: 1.20.2-1.el7

1) Have two product certs with product certs sharing same products 

[root@hp-sl4545g7-01 home]# rct cc /etc/pki/product/76.pem | grep Tags:
	Tags: rhel-7,rhel-7-computenode
[root@hp-sl4545g7-01 home]# rct cc /etc/pki/product/69.pem | grep Tags:
	Tags: rhel-7,rhel-7-server


2) attach subscriptions 

[root@hp-sl4545g7-01 home]# subscription-manager attach --auto
Installed Product Current Status:
Product Name: Red Hat Enterprise Linux for Scientific Computing
Status:       Subscribed

Product Name: Red Hat Enterprise Linux Server
Status:       Subscribed

[root@hp-sl4545g7-01 home]# subscription-manager list --consumed
+-------------------------------------------+
   Consumed Subscriptions
+-------------------------------------------+
Subscription Name:   Red Hat Enterprise Linux Server, Standard (Physical Node with up to 4 Virtual Nodes) (L3 Only)
Provides:            Red Hat Software Collections (for RHEL Server)
                     dotNET on RHEL Beta (for RHEL Server)
                     dotNET on RHEL (for RHEL Server)
                     Red Hat Beta
                     Red Hat Software Collections Beta (for RHEL Server)
                     Red Hat Developer Tools Beta (for RHEL Server)
                     Red Hat Developer Toolset (for RHEL Server)
                     Oracle Java (for RHEL Server)
                     Red Hat Enterprise Linux Server
                     Red Hat Developer Tools (for RHEL Server)
SKU:                 RH00137F3
Contract:            11488972
Account:             6117003
Serial:              4860623779962757562
Pool ID:             8a99f9835f01e06a015f0a6bcb9c2c0c
Provides Management: No
Active:              True
Quantity Used:       1
Service Level:       Standard
Service Type:        L3
Status Details:      Subscription is current
Subscription Type:   Stackable
Starts:              10/11/2017
Ends:                10/10/2020
System Type:         Physical

Subscription Name:   Red Hat Enterprise Linux for HPC Compute Nodes, Basic (up to 2 sockets) Additional Nodes
Provides:            Red Hat Beta
                     Oracle Java (for RHEL Client)
                     Red Hat Hardware Certification Test Suite
                     Oracle Java (for RHEL Server)
                     Oracle Java (for RHEL Compute Node)
                     Red Hat Enterprise Linux for Scientific Computing
SKU:                 MCT0980
Contract:            11504433
Account:             6117003
Serial:              7993484902015760418
Pool ID:             8a99f9835f5e5538015f5e60c812001d
Provides Management: No
Active:              True
Quantity Used:       1
Service Level:       Basic
Service Type:        L1-L3
Status Details:      Subscription is current
Subscription Type:   Standard
Starts:              10/27/2017
Ends:                10/26/2018
System Type:         Physical

3) try to list /set release version 

[root@hp-sl4545g7-01 home]# subscription-manager release --list
Error: More than one release product certificate installed.

[root@hp-sl4545g7-01 home]# subscription-manager release --set=7.3
Error: More than one release product certificate installed.


rhsm.log 
--------

# subscription-manager release --list
2017-10-27 11:15:08,400 [INFO] subscription-manager:13293:MainThread @managercli.py:453 - X-Correlation-ID: 64784c32dba146a286902e8b43597fb0
2017-10-27 11:15:08,400 [INFO] subscription-manager:13293:MainThread @managercli.py:342 - Client Versions: {'python-rhsm': '1.20.2-1.el7', 'subscription-manager': '1.20.2-1.el7'}
2017-10-27 11:15:08,402 [INFO] subscription-manager:13293:MainThread @connection.py:832 - Connection built: host=subscription.rhsm.stage.redhat.com port=443 handler=/subscription auth=identity_cert ca_dir=/etc/rhsm/ca/ insecure=False
2017-10-27 11:15:08,403 [INFO] subscription-manager:13293:MainThread @connection.py:832 - Connection built: host=subscription.rhsm.stage.redhat.com port=443 handler=/subscription auth=none
2017-10-27 11:15:08,404 [INFO] subscription-manager:13293:MainThread @managercli.py:317 - Consumer Identity name=hp-sl4545g7-01.khw.lab.eng.bos.redhat.com uuid=b1be0058-47f6-4c2b-bbef-14edd62be30f
2017-10-27 11:15:08,866 [INFO] subscription-manager:13293:MainThread @connection.py:556 - Response: status=200, request="GET /subscription/"
2017-10-27 11:15:08,875 [ERROR] subscription-manager:13293:MainThread @managercli.py:1433 - Getting releases failed: More than one product with RHEL product tags found.

Observed error message on terminal "Error: More than one release product certificate installed." is displayed and 

rhsm.log reports 
"Getting releases failed: More than one product with RHEL product tags found"


We have following recommendations: 

1) We feel it would be nice to display the product certificate location in the log 

2) Also modify the terminal error message accordingly.

Created attachment 1347184 [details]
Preference dialogue is frozen

Observation on GUI(Attachment in comment 7):

[root@hp-ms-01-c43 ~]# subscription-manager version
server type: Red Hat Subscription Management
subscription management server: 2.0.43-1
subscription management rules: 5.26
subscription-manager: 1.20.2-1.el7
python-rhsm: 1.20.2-1.el7

Preference dialogue of GUI is frozen and cannot modify the service-level or enable/disable auto-attach preference and with a following traceback on terminal

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/subscription_manager/gui/preferences.py", line 101, in load_from_consumer_json
    self.load_releases(consumer_json)
  File "/usr/lib/python2.7/site-packages/subscription_manager/gui/preferences.py", line 144, in load_releases
    available_releases = self.release_backend.get_releases()
  File "/usr/lib/python2.7/site-packages/subscription_manager/release.py", line 52, in get_releases
    return provider.get_releases()
  File "/usr/lib/python2.7/site-packages/subscription_manager/release.py", line 103, in get_releases
    raise MultipleReleaseProductsError("More than one product with RHEL product tags found.")
subscription_manager.release.MultipleReleaseProductsError: More than one product with RHEL product tags found.

Would have preferred:

1)Error message pop up saying "Error: More than one release product certificate installed."

2) Instead of a traceback error message being logged in /var/log/rhsm/rhsm.log file

Moving bug back to new(failed_qa) as Preference dialogue of GUI is frozen and cannot modify the service-level or enable/disable auto-attach preference and with a following traceback on terminal as mentioned in comment 8

Clearing fixed-in-version. Next release will have a fix (see attached PR). I'll set to ON_QA and re-set the fixed-in-version once we get another build out.

Retested with ;
subscription-manager: 1.20.7-1.el7

I could still see all the three failures mentioned (comment 8 and 6 ) 

1) GUI preference dialog is frozen with traceback on terminal 

Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/subscription_manager/gui/preferences.py", line 101, in load_from_consumer_json
    self.load_releases(consumer_json)
  File "/usr/lib64/python2.7/site-packages/subscription_manager/gui/preferences.py", line 144, in load_releases
    available_releases = self.release_backend.get_releases()
  File "/usr/lib64/python2.7/site-packages/subscription_manager/release.py", line 52, in get_releases
    return provider.get_releases()
  File "/usr/lib64/python2.7/site-packages/subscription_manager/release.py", line 103, in get_releases
    raise MultipleReleaseProductsError("More than one product with RHEL product tags found.")
subscription_manager.release.MultipleReleaseProductsError: More than one product with RHEL product tags found.


2) Also can you please confirm if the recommendations in comment 6 will be implemented or not 

a) would like to see the installed product id location being reported in the rhsm.log along with the error message ' [ERROR] subscription-manager:88108:MainThread @managercli.py:1437 - Getting releases failed: More than one product with RHEL product tags found.'

b) to change the terminal error message
  from "Error: More than one release product certificate installed." 
 to "Error: More than one product certificate installed."

Please note that we have not fixed the GUI freeze. Shwetha, please open a separate BZ for the GUI freeze.

> a) would like to see the installed product id location being reported in the rhsm.log along with the error message ' [ERROR] subscription-manager:88108:MainThread @managercli.py:1437 - Getting releases failed: More than one product with RHEL product tags found.'

Yes the next release of subscription-manager will contain the locations reported.

> b) to change the terminal error message
  from "Error: More than one release product certificate installed." 
 to "Error: More than one product certificate installed."

We're going with the language: "More than one release product certificate installed."

Verification for GUI with following version of rhsm:

[root@bkr-hv01-guest15 ~]# subscription-manager version
server type: Red Hat Subscription Management
subscription management server: 2.0.43-1
subscription management rules: 5.26
subscription-manager: 1.20.8-1.el7

Error dialog pops up saying "More than one release product certificate installed"
P.S : Attachment : "Error Message" for complete error message

Preference Dialogue of GUI no longer freezes
P.S : Attachment : "Preference Dialogue of GUI no longer freezes"


Error gets logged into rhsm.log file now:
-----------------------------------------------

[root@bkr-hv01-guest15 ~]# tail -f /var/log/rhsm/rhsm.log 
2017-12-13 08:11:18,961 [INFO] subscription-manager-gui:6526:MainThread @dmiinfo.py:75 - Using dmidecode dump file: /dev/mem
2017-12-13 08:11:19,903 [INFO] subscription-manager-gui:6526:MainThread @connection.py:586 - Response: status=200, requestUuid=cc846866-6434-457c-be06-636d813d1f96, request="GET /subscription/consumers/3720e1b5-6680-44c8-8d1c-8c3c7781168a/owner"
2017-12-13 08:11:33,510 [INFO] subscription-manager-gui:6526:AsyncWidgetUpdaterThread @connection.py:586 - Response: status=200, requestUuid=6c1465c4-d1eb-4505-877f-d1ee70345655, request="GET /subscription/consumers/3720e1b5-6680-44c8-8d1c-8c3c7781168a"
2017-12-13 08:11:33,511 [WARNING] subscription-manager-gui:6526:AsyncWidgetUpdaterThread @connection.py:590 - Clock skew detected, please check your system time
2017-12-13 08:11:33,512 [ERROR] subscription-manager-gui:6526:MainThread @preferences.py:148 - Getting releases failed: More than one release product certificate installed. Certificate paths: /etc/pki/product-default/69.pem, /etc/pki/product-default/71.pem, /etc/pki/product-default/76.pem
2017-12-13 08:11:34,155 [INFO] subscription-manager-gui:6526:MainThread @connection.py:586 - Response: status=200, requestUuid=79ca51fe-6864-4056-bc77-1866b948f868, request="GET /subscription/owners/11343157/servicelevels"

Created attachment 1367352 [details]
Preference Dialogue of GUI no longer freezes

Created attachment 1367353 [details]
Error Message

Verifying CLI error message and rhsm.log on : 
# subscription-manager version
server type: Red Hat Subscription Management
subscription management server: 2.0.43-1
subscription management rules: 5.26
subscription-manager: 1.20.8-1.el7


[root@dhcp180-233 ~]# subscription-manager release --list
Error: More than one release product certificate installed. Certificate paths: /etc/pki/product-default/69.pem, /etc/pki/product/230.pem

rhsm.log
---------

[root@dhcp180-233 ~]# tail -f /var/log/rhsm/rhsm.log 
2017-12-13 08:01:06,354 [INFO] subscription-manager:29445:MainThread @managercli.py:317 - Consumer Identity name=dhcp180-233.ml3.eng.bos.redhat.com uuid=e60a0881-6be6-4ebb-ade2-13a3c942a8b8
2017-12-13 08:01:06,842 [INFO] subscription-manager:29445:MainThread @connection.py:586 - Response: status=200, request="GET /subscription/"
2017-12-13 08:01:06,844 [ERROR] subscription-manager:29445:MainThread @managercli.py:1433 - Getting releases failed: More than one release product certificate installed. Certificate paths: /etc/pki/product-default/69.pem, /etc/pki/product/230.pem
2017-12-13 08:01:15,412 [INFO] subscription-manager:29457:MainThread @managercli.py:452 - X-Correlation-ID: 9a90cc90786644808cf59b2c43a8032f
2017-12-13 08:01:15,412 [INFO] subscription-manager:29457:MainThread @managercli.py:341 - Client Versions: {'subscription-manager': '1.20.8-1.el7'}
2017-12-13 08:01:15,413 [INFO] subscription-manager:29457:MainThread @connection.py:868 - Connection built: host=subscription.rhsm.stage.redhat.com port=443 handler=/subscription auth=identity_cert ca_dir=/etc/rhsm/ca/ insecure=False
2017-12-13 08:01:15,413 [INFO] subscription-manager:29457:MainThread @connection.py:868 - Connection built: host=subscription.rhsm.stage.redhat.com port=443 handler=/subscription auth=none
2017-12-13 08:01:15,413 [INFO] subscription-manager:29457:MainThread @managercli.py:317 - Consumer Identity name=dhcp180-233.ml3.eng.bos.redhat.com uuid=e60a0881-6be6-4ebb-ade2-13a3c942a8b8
2017-12-13 08:01:15,901 [INFO] subscription-manager:29457:MainThread @connection.py:586 - Response: status=200, request="GET /subscription/"

2017-12-13 08:01:15,904 [ERROR] subscription-manager:29457:MainThread @managercli.py:1433 - Getting releases failed: More than one release product certificate installed. Certificate paths: /etc/pki/product-default/69.pem, /etc/pki/product/230.pem
^^^ notice the patch to the product certificate location 

Observed that now both CLI and rhsm.log displays the product certificate locations along with the error message " Error: More than one release product certificate installed"

Based on comment 15 and comment 18 marking the bug as Verified!!

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0681