Bug 1464975
| Summary: | can not hotplug a disk with the same WWN which already used in the guest | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | lijuan men <lmen> |
| Component: | libvirt | Assignee: | Peter Krempa <pkrempa> |
| Status: | CLOSED ERRATA | QA Contact: | Meina Li <meili> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 7.4 | CC: | dyuan, pkrempa, rbalakri, xuzhang |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | libvirt-3.7.0-1.el7 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-04-10 10:50:46 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
lijuan men
2017-06-26 10:36:56 UTC
Fixed upstream:
commit d65781bf061fb6369494b381c908ec2e08b05769
Author: Peter Krempa <pkrempa>
Date: Fri Jun 23 14:11:25 2017 +0200
tests: hotplug: Test disks with duplicate WWNs
commit b910fa8b76d9b4f5fc06dc1eccd5ca6ea80b94ad
Author: Peter Krempa <pkrempa>
Date: Wed Jun 21 11:44:59 2017 +0200
Revert "qemu: Check duplicate WWNs also for hotplugged disks"
Similarly to commit 5da28cc3069b573f54f0bcaf8eb75476bcfdc6e9 this check
actually does not make sense since duplicate WWNs are used e.g. when
multipathing disks.
This reverts commit 780fe4e4baf7e2f10f65ba1a34f9274fc547cad2.
Test env components:
kernel-3.10.0-748.el7.x86_64
libvirt-3.8.0-1.el7.x86_64
qemu-kvm-rhev-2.10.0-2.el7.x86_64
Steps to verify:
1. Start a guest with 2 disks which have the same WWN.
1)start a guest with :
<disk type='file' device='disk'>
<driver name='qemu' type='qcow2'/>
<source file='/var/lib/libvirt/images/test.qcow2'/>
<target dev='hda' bus='ide'/>
<wwn>0x5000c50015ea71aa</wwn>
<address type='drive' controller='0' bus='0' target='0' unit='0'/>
</disk>
<disk type='file' device='disk'>
<driver name='qemu' type='raw'/>
<source file='/var/lib/libvirt/images/test.raw'/>
<target dev='sda' bus='scsi'/>
<readonly/>
<shareable/>
<wwn>0x5000c50015ea71aa</wwn>
<address type='drive' controller='0' bus='0' target='0' unit='0'/>
</disk>
2)In the guest, check the disk:
# lsblk
NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINT
sda 8:0 0 1G 0 disk
sdb 8:16 0 1G 0 disk
vda 252:0 0 10G 0 disk
├─vda1 252:1 0 1G 0 part /boot
└─vda2 252:2 0 9G 0 part
├─rhel-root 253:0 0 8G 0 lvm /
└─rhel-swap 253:1 0 1G 0 lvm [SWAP]
2. Attach a scsi disk with the same WWN.
1)start a guest with:
<disk type='file' device='disk'>
<driver name='qemu' type='qcow2'/>
<source file='/var/lib/libvirt/images/test.qcow2'/>
<target dev='hda' bus='ide'/>
<wwn>0x5000c50015ea71aa</wwn>
<address type='drive' controller='0' bus='0' target='0' unit='0'/>
</disk>
2) attach a disk with the follow xml:
# cat disk.xml
<disk type='file' device='disk'>
<driver name='qemu' type='raw'/>
<source file='/var/lib/libvirt/images/test.raw'/>
<target dev='sda' bus='scsi'/>
<readonly/>
<shareable/>
<wwn>0x5000c50015ea71aa</wwn>
<address type='drive' controller='0' bus='0' target='0' unit='0'/>
</disk>
# virsh attach-device lmn disk.xml
Device attached successfully
3)In the guest, check the disk:
# lsblk
NAME MAJ:MIN RM SIZE RO TYPE MOUNTPOINT
sda 8:0 0 1G 0 disk
sdb 8:16 0 1G 0 disk
vda 252:0 0 10G 0 disk
├─vda1 252:1 0 1G 0 part /boot
└─vda2 252:2 0 9G 0 part
├─rhel-root 253:0 0 8G 0 lvm /
└─rhel-swap 253:1 0 1G 0 lvm [SWAP]
4)detach the disk:
virsh detach-device lmn disk.xml
Device detached successfully
The results are as expected.
In addition, the documentation says: If present, this element specifies the WWN (World Wide Name) of a virtual hard disk or CD-ROM drive. It must be composed of 16 hexadecimal digits and must be unique (at least among disks of a single domain).
And this is inconsistent with the bug，so how can we deal with it or file a new bug?
I've fixed the docs upstream:
commit 8587bb4549635397dc912b26906cdbe124a073db
Author: Peter Krempa <pkrempa>
Date: Thu Oct 26 10:28:12 2017 +0200
docs: Drop mention that WWN for disks must be unique
For multipath disks it might be useful to have the same WWN for multiple
disks. It's the users choice to do so. Since we dropped the check that
disallows using duplicate WWNs drop the docs as well.
The docs result is as expected. Move this Bug to verified. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2018:0704 |