Bug 1465313 (bacon/bacon-qr-code) - Review Request: php-bacon-qr-code - QR code generator for PHP
Summary: Review Request: php-bacon-qr-code - QR code generator for PHP
Keywords:
Status: CLOSED ERRATA
Alias: bacon/bacon-qr-code
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Shawn Iwinski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-06-27 07:48 UTC by Remi Collet
Modified: 2017-07-19 05:49 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-07-11 20:55:25 UTC
Type: ---
Embargoed:
shawn: fedora-review+


Attachments (Terms of Use)
phpcompatinfo-full.log (12.90 KB, text/plain)
2017-07-03 01:15 UTC, Shawn Iwinski
no flags Details
phpcompatinfo-lib.log (10.68 KB, text/plain)
2017-07-03 01:15 UTC, Shawn Iwinski
no flags Details
fedora-review.txt (7.31 KB, text/plain)
2017-07-03 01:16 UTC, Shawn Iwinski
no flags Details

Description Remi Collet 2017-06-27 07:48:36 UTC
Spec URL: https://git.remirepo.net/cgit/rpms/php/bacon/php-bacon-qr-code.git/plain/php-bacon-qr-code.spec?id=a782099d313044e816067a0b805b3beb222d9578
SRPM URL: http://rpms.remirepo.net/SRPMS/php-bacon-qr-code-1.0.1-1.remi.src.rpm
Description: 
BaconQrCode is a port of QR code portion of the ZXing library.
It currently only features the encoder part, but could later
receive the decoder part as well.

As the Reed Solomon codec implementation of the ZXing library
performs quite slow in PHP, it was exchanged with the implementation
by Phil Karn.

Autoloader: /usr/share/php/BaconQrCode/autoload.php


Fedora Account System Username: remi

--

New dependency of roundcubemail

Comment 1 Shawn Iwinski 2017-07-03 01:15:32 UTC
Created attachment 1293698 [details]
phpcompatinfo-full.log

phpCompatInfo version 5.0.7 DB version 1.22.0 built Jun 10 2017 11:10:50 CEST

Comment 2 Shawn Iwinski 2017-07-03 01:15:53 UTC
Created attachment 1293699 [details]
phpcompatinfo-lib.log

phpCompatInfo version 5.0.7 DB version 1.22.0 built Jun 10 2017 11:10:50 CEST

Comment 3 Shawn Iwinski 2017-07-03 01:16:26 UTC
Created attachment 1293700 [details]
fedora-review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug 1465313
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 4 Shawn Iwinski 2017-07-03 01:16:52 UTC
Minor blocker:

[!]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/php(php-common)

     Remove `%dir %{php_home}/%{ns_vendor}` since `%{ns_vendor}` is `%nil`

Comment 6 Shawn Iwinski 2017-07-03 04:22:59 UTC
-%dir %{php_home}/%{ns_vendor}
-     %{php_home}/%{ns_vendor}/%{ns_project}
+%{php_home}/%{ns_project}

[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/php(php-common)



No blockers.

===== APPROVED =====

Comment 7 Remi Collet 2017-07-03 04:28:57 UTC
Thanks for the review.

Comment 8 Gwyn Ciesla 2017-07-03 11:23:27 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-bacon-qr-code

Comment 9 Fedora Update System 2017-07-03 13:47:03 UTC
php-bacon-qr-code-1.0.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-c2afe357bb

Comment 10 Fedora Update System 2017-07-03 18:25:48 UTC
php-bacon-qr-code-1.0.1-4.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5733820059

Comment 11 Fedora Update System 2017-07-04 02:17:41 UTC
php-bacon-qr-code-1.0.1-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-c2afe357bb

Comment 12 Fedora Update System 2017-07-04 03:21:25 UTC
php-bacon-qr-code-1.0.1-4.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ed3b6991da

Comment 13 Fedora Update System 2017-07-11 20:55:25 UTC
php-bacon-qr-code-1.0.1-4.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2017-07-12 03:23:46 UTC
php-bacon-qr-code-1.0.1-4.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2017-07-19 05:49:08 UTC
php-bacon-qr-code-1.0.1-4.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.