Bug 1465494 - Review Request: perl-System-Info - Factory for system specific information objects
Review Request: perl-System-Info - Factory for system specific information ob...
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Petr Pisar
Fedora Extras Quality Assurance
:
Depends On:
Blocks: 1450709
  Show dependency treegraph
 
Reported: 2017-06-27 10:16 EDT by Jitka Plesnikova
Modified: 2017-06-28 09:27 EDT (History)
2 users (show)

See Also:
Fixed In Version: perl-System-Info-0.055-1.fc27
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2017-06-28 09:27:57 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ppisar: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Jitka Plesnikova 2017-06-27 10:16:14 EDT
Spec URL: https://jplesnik.fedorapeople.org/perl-System-Info/perl-System-Info.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-System-Info/perl-System-Info-0.055-1.fc27.src.rpm

Description:
System::Info tries to present system-related information, like number of
CPU's, architecture, OS and release related information in a system-
independent way. This releases the user of this module of the need to know
if the information comes from Windows, Linux, HP-UX, AIX, Solaris, Irix, or
VMS, and if the architecture is i386, x64, pa-risc2, or arm.

Fedora Account System Username: jplesnik@redhat.com
Comment 1 Petr Pisar 2017-06-27 10:58:43 EDT
URL and Source0 addresses are usable. Ok.
Source0 archive (SHA-256: 9e44839f9ca8949711d7320a02f359bc8a61716b3fe27182f2a0b1e6fd1b350c) is original. Ok.
The System-Info-0.055-Add-arm-for-aarch64-RT-119691.patch is Ok.
Summary verified from lib/System/Info.pm. Ok.
Description verified from lib/System/Info.pm. Ok.
License verified from README, lib/System/Info/Base.pm, lib/System/Info.pm and other files. Ok.
No XS files, noarch BuildArch is Ok.

TODO: Align Patch0 value indentation to other items.

The Win32 and Haiku::SysInfo modules are not used. Ok.

Fix: Build-require `perl(Carp)' for runnig tests (t/sysinfo_macos.t:12).
FIX: Do not build-require `perl(Data::Peek)'. It's not used anywhere.

All tests pass. Ok.

$ rpmlint perl-System-Info.spec ../SRPMS/perl-System-Info-0.055-1.fc27.src.rpm ../RPMS/noarch/perl-System-Info-0.055-1.fc27.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-System-Info-0.055-1.fc27.noarch.rpm t@fedora-27 SPECS]$ rpm -q -lv -p ../RPMS/noarch/perl-System-Info-0.055-1.fc27.noarch.rpm
drwxr-xr-x    2 root    root                        0 Jun 27 16:47 /usr/share/doc/perl-System-Info
-rw-r--r--    1 root    root                      783 Apr 24  2016 /usr/share/doc/perl-System-Info/CONTRIBUTING.md
-rw-r--r--    1 root    root                     1022 May 12 12:16 /usr/share/doc/perl-System-Info/ChangeLog
-rw-r--r--    1 root    root                     1451 Feb 28 18:22 /usr/share/doc/perl-System-Info/README
-rw-r--r--    1 root    root                     2208 Jun 27 16:47 /usr/share/man/man3/System::Info.3pm.gz
-rw-r--r--    1 root    root                     1883 Jun 27 16:47 /usr/share/man/man3/System::Info::AIX.3pm.gz
-rw-r--r--    1 root    root                     1627 Jun 27 16:47 /usr/share/man/man3/System::Info::BSD.3pm.gz
-rw-r--r--    1 root    root                     2267 Jun 27 16:47 /usr/share/man/man3/System::Info::Base.3pm.gz
-rw-r--r--    1 root    root                     1657 Jun 27 16:47 /usr/share/man/man3/System::Info::Cygwin.3pm.gz
-rw-r--r--    1 root    root                     1617 Jun 27 16:47 /usr/share/man/man3/System::Info::Darwin.3pm.gz
-rw-r--r--    1 root    root                     1575 Jun 27 16:47 /usr/share/man/man3/System::Info::Generic.3pm.gz
-rw-r--r--    1 root    root                     1622 Jun 27 16:47 /usr/share/man/man3/System::Info::HPUX.3pm.gz
-rw-r--r--    1 root    root                     1618 Jun 27 16:47 /usr/share/man/man3/System::Info::Haiku.3pm.gz
-rw-r--r--    1 root    root                     1644 Jun 27 16:47 /usr/share/man/man3/System::Info::Irix.3pm.gz
-rw-r--r--    1 root    root                     2234 Jun 27 16:47 /usr/share/man/man3/System::Info::Linux.3pm.gz
-rw-r--r--    1 root    root                     1652 Jun 27 16:47 /usr/share/man/man3/System::Info::Solaris.3pm.gz
-rw-r--r--    1 root    root                     1645 Jun 27 16:47 /usr/share/man/man3/System::Info::VMS.3pm.gz
-rw-r--r--    1 root    root                     1648 Jun 27 16:47 /usr/share/man/man3/System::Info::Windows.3pm.gz
drwxr-xr-x    2 root    root                        0 Jun 27 16:47 /usr/share/perl5/vendor_perl/System
drwxr-xr-x    2 root    root                        0 Jun 27 16:47 /usr/share/perl5/vendor_perl/System/Info
-rw-r--r--    1 root    root                     3702 May 12 14:12 /usr/share/perl5/vendor_perl/System/Info.pm
-rw-r--r--    1 root    root                     3296 Feb 28 18:22 /usr/share/perl5/vendor_perl/System/Info/AIX.pm
-rw-r--r--    1 root    root                     2103 Feb 28 18:22 /usr/share/perl5/vendor_perl/System/Info/BSD.pm
-rw-r--r--    1 root    root                     4397 Feb 28 18:22 /usr/share/perl5/vendor_perl/System/Info/Base.pm
-rw-r--r--    1 root    root                     1478 Feb 28 18:22 /usr/share/perl5/vendor_perl/System/Info/Cygwin.pm
-rw-r--r--    1 root    root                     3334 May 12 12:15 /usr/share/perl5/vendor_perl/System/Info/Darwin.pm
-rw-r--r--    1 root    root                      952 Feb 28 18:22 /usr/share/perl5/vendor_perl/System/Info/Generic.pm
-rw-r--r--    1 root    root                     3781 Feb 28 18:22 /usr/share/perl5/vendor_perl/System/Info/HPUX.pm
-rw-r--r--    1 root    root                     1488 Feb 28 18:22 /usr/share/perl5/vendor_perl/System/Info/Haiku.pm
-rw-r--r--    1 root    root                     1885 Feb 28 18:22 /usr/share/perl5/vendor_perl/System/Info/Irix.pm
-rw-r--r--    1 root    root                    11988 Jun 27 16:47 /usr/share/perl5/vendor_perl/System/Info/Linux.pm
-rw-r--r--    1 root    root                     2583 Feb 28 18:22 /usr/share/perl5/vendor_perl/System/Info/Solaris.pm
-rw-r--r--    1 root    root                     1611 Feb 28 18:22 /usr/share/perl5/vendor_perl/System/Info/VMS.pm
-rw-r--r--    1 root    root                     2785 Feb 28 18:22 /usr/share/perl5/vendor_perl/System/Info/Windows.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-System-Info-0.055-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.26.0)
      1 perl(base)
      1 perl(Exporter)
      1 perl(POSIX)
      1 perl(strict)
      1 perl(System::Info::AIX)
      1 perl(System::Info::Base)
      1 perl(System::Info::BSD)
      1 perl(System::Info::Cygwin)
      1 perl(System::Info::Darwin)
      1 perl(System::Info::Generic)
      1 perl(System::Info::Haiku)
      1 perl(System::Info::HPUX)
      1 perl(System::Info::Irix)
      1 perl(System::Info::Linux)
      1 perl(System::Info::Solaris)
      1 perl(System::Info::VMS)
      1 perl(System::Info::Windows)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Run-time binary dependencies are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-System-Info-0.055-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(System::Info) = 0.055
      1 perl(System::Info::AIX) = 0.050
      1 perl(System::Info::Base) = 0.050
      1 perl(System::Info::BSD) = 0.050
      1 perl(System::Info::Cygwin) = 0.050
      1 perl(System::Info::Darwin) = 0.051
      1 perl(System::Info::Generic) = 0.050
      1 perl(System::Info::Haiku) = 0.050
      1 perl(System::Info::HPUX) = 0.050
      1 perl(System::Info::Irix) = 0.050
      1 perl(System::Info::Linux) = 0.052
      1 perl(System::Info::Solaris) = 0.050
      1 perl(System::Info::VMS) = 0.050
      1 perl(System::Info::Windows) = 0.050
      1 perl-System-Info = 0.055-1.fc27
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-System-Info-0.055-1.fc27.noarch.rpm 
Binary dependencies resolvable. Ok.
Ok.

Package builds in F27 (https://koji.fedoraproject.org/koji/taskinfo?taskID=20208611). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct the `FIX' items and consider fixing the `TODO' item before building this package.
Comment 2 Gwyn Ciesla 2017-06-28 08:37:00 EDT
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-System-Info
Comment 3 Jitka Plesnikova 2017-06-28 09:27:57 EDT
Spec file was updated due to comments.

Thank you for the review and the repository.

Note You need to log in before you can comment on or make changes to this bug.