Bug 1465829 - pcs should warn when setting utilization attributes may unexpectedly have no effect
pcs should warn when setting utilization attributes may unexpectedly have no ...
Status: NEW
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: pcs (Show other bugs)
7.4
Unspecified Unspecified
medium Severity unspecified
: rc
: ---
Assigned To: Tomas Jelinek
cluster-qe@redhat.com
: FutureFeature
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2017-06-28 06:06 EDT by Jan Pokorný
Modified: 2017-07-21 07:03 EDT (History)
6 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Jan Pokorný 2017-06-28 06:06:57 EDT
Unfortunately, [bug 1158500] missed this guidance point completely
(also because the effect of utilization was never properly tested?).

When setting utilization attribute while the placement-strategy is
"default" (implicitly or not) ...

1. ... on-the-fly: emit guidance message that placement-strategy cluster
   property needs to be changed for the current change to take effect

2. ... accumulate + push:  ditto as for 1. + make the "grand check"
   in the push stage that will verify that the final CIB indeed
   carries placement-strategy set to non-default, if not, emit
   the warning once more + perhaps prevent the push unless --force
   is specified

Note also there's no restriction of available values for
placement-strategy values in the current code.

References:
http://clusterlabs.org/doc/en-US/Pacemaker/1.1-pcs/html-single/Pacemaker_Explained/index.html#_placement_strategy
Comment 1 Tomas Jelinek 2017-06-28 06:27:00 EDT
Some kind of warning should be present in both cli and gui.


In reply to Jan Pokorný from comment #0)
> Note also there's no restriction of available values for
> placement-strategy values in the current code.

It would be nice if pacemaker specified allowed values of cluster properties in pengine metadata (and others) in a nicely parsable form.
Comment 2 Tomas Jelinek 2017-06-28 06:32:55 EDT
Also this should be covered in documentation and pcs man page / usage.
Comment 4 Jan Pokorný 2017-06-28 10:39:45 EDT
Disclosure:
This is what has rung a bell for me about this configuration
intertwining (thanks, Ken): 
http://oss.clusterlabs.org/pipermail/users/2017-June/005907.html

Note there's also a precedent in pcs where the clash between
the non-properties configuration and particular cluster property
is also accompanied with a whistleblowing:

https://github.com/ClusterLabs/pcs/commit/e5ce08e

Note You need to log in before you can comment on or make changes to this bug.