Red Hat Bugzilla – Bug 1465907
On Qemu/KVM deselecting any USB target from redirection instantaneously takes effect without validation of the choice.
Last modified: 2017-07-17 16:00:59 EDT
Created attachment 1292645 [details]
Deselecting any USB target from redirection instantaneously takes effect without validation of the choice.
Description of problem:
Just by deselecting any USB target from redirection leads to take effect instantaneously and that even without validation of the choice to be required.
Version-Release number of selected component (if applicable):
1.4.1-2.fc25 | x86_64
Steps to Reproduce:
1. On Qemu/KVM run a virtual machine. Verify that for example a USB storage is redirected to the VM. (If not select it in Redirect USB device)
2. Once redirected, deselect it.
Deselecting any USB target (as example a USB storage) from redirection will instantaneously take effect without validation of the choice to be required.
The validation should obviously in that case require OK to be clicked.
That UI comes from spice-gtk, so reassigning
(In reply to Cole Robinson from comment #1)
> That UI comes from spice-gtk, so reassigning
spice-gtk only gives you the list of usb devices.
the "ok" button is in virt-manager.
I'd suggest renaming "OK" to "Close" (or removing the button)
Okay I switched the button text from OK -> Close to try and make it more clear that selection takes place immediately. Any change in behavior beyond that will have to start with spice-gtk work since it doesn't allow any different interaction logic than 'click immediately redirects the device'
commit 7d03190cb527ad6921b1ac2cd69834dfe47e6196 (HEAD -> master)
Author: Cole Robinson <firstname.lastname@example.org>
Date: Mon Jul 17 15:46:12 2017 -0400
spice: s/OK/Close/ in USB redirection dialog (bz 1465907)