Bug 1466337 - Review Request: perl-MooX-Locale-Passthrough - Provide API used in translator modules without translating
Summary: Review Request: perl-MooX-Locale-Passthrough - Provide API used in translator...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1465429
TreeView+ depends on / blocked
 
Reported: 2017-06-29 13:07 UTC by Jitka Plesnikova
Modified: 2017-06-30 13:10 UTC (History)
2 users (show)

Fixed In Version: perl-MooX-Locale-Passthrough-0.001-1.fc27
Clone Of:
Environment:
Last Closed: 2017-06-30 13:10:16 UTC
Type: ---
Embargoed:
ppisar: fedora-review+


Attachments (Terms of Use)

Description Jitka Plesnikova 2017-06-29 13:07:38 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-MooX-Locale-Passthrough/perl-MooX-Locale-Passthrough.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-MooX-Locale-Passthrough/perl-MooX-Locale-Passthrough-0.001-1.fc27.src.rpm

Description:
MooX::Locale::Passthrough is made to allow CPAN modules use translator API
without adding heavy dependencies (external software) or requirements
(operating resulting solution).

Fedora Account System Username: jplesnik

Comment 1 Petr Pisar 2017-06-30 07:12:58 UTC
URL and Source0 addresses are Ok.
Source0 archive (SHA-256: 7a05827e52ab5a1dde2ea5c712927b1e58c8d251664d966627adf9dd30ec0512) is original. Ok.
Summary verified from lib/MooX/Locale/Passthrough.pm. Ok.
Description verified from lib/MooX/Locale/Passthrough.pm. Ok.
License verified from README.md and lib/MooX/Locale/Passthrough.pm. Ok.
No XS code, noarch BuildArch is Ok.
Build-time dependencies are Ok.
All tests pass. Ok.

$ rpmlint perl-MooX-Locale-Passthrough.spec ../SRPMS/perl-MooX-Locale-Passthrough-0.001-1.fc27.src.rpm ../RPMS/noarch/perl-MooX-Locale-Passthrough-0.001-1.fc27.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-MooX-Locale-Passthrough-0.001-1.fc27.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jun 30 09:08 /usr/share/doc/perl-MooX-Locale-Passthrough
-rw-r--r--    1 root    root                      122 May 31 11:43 /usr/share/doc/perl-MooX-Locale-Passthrough/Changes
-rw-r--r--    1 root    root                     2331 May 30 18:34 /usr/share/doc/perl-MooX-Locale-Passthrough/README.md
-rw-r--r--    1 root    root                     2097 Jun 30 09:08 /usr/share/man/man3/MooX::Locale::Passthrough.3pm.gz
drwxr-xr-x    2 root    root                        0 Jun 30 09:08 /usr/share/perl5/vendor_perl/MooX
drwxr-xr-x    2 root    root                        0 Jun 30 09:08 /usr/share/perl5/vendor_perl/MooX/Locale
-rw-r--r--    1 root    root                     2435 May 30 18:32 /usr/share/perl5/vendor_perl/MooX/Locale/Passthrough.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-MooX-Locale-Passthrough-0.001-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.26.0)
      1 perl(Carp)
      1 perl(Moo::Role) >= 1.003
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-MooX-Locale-Passthrough-0.001-1.fc27.noarch.rpm | sort -f | uniq -c
      1 perl(MooX::Locale::Passthrough) = 0.001
      1 perl-MooX-Locale-Passthrough = 0.001-1.fc27
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-MooX-Locale-Passthrough-0.001-1.fc27.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F27 (https://koji.fedoraproject.org/koji/taskinfo?taskID=20259108). Ok.

Package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.

Comment 2 Gwyn Ciesla 2017-06-30 12:04:19 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-MooX-Locale-Passthrough

Comment 3 Jitka Plesnikova 2017-06-30 13:10:16 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.