Description of problem:
Currently when deploying a containers environment with pacemaker enabled we need to pass docker.yaml and docker-ha.yaml environment files to the overcloud deploy command. Since the deployment should be containerized by default I propose to include these environments files by default and not require the user to specifically pass them to the deploy command. Having to pass many environment files can become confusing for the user.
Defaulting environments could get tricky too. Are we defaulting the previous downstream templates in this regard? What I mean is are we for example automatically including environments/puppet-pacemaker.yaml downstream?
after bug triaged meeting - we said it might be an RFE , but not sure that having this as default is what we really want.
Need info PM
(In reply to Dan Prince from comment #1)
> Defaulting environments could get tricky too. Are we defaulting the previous
> downstream templates in this regard? What I mean is are we for example
> automatically including environments/puppet-pacemaker.yaml downstream?
Yes, please see bug 1406869 as reference for OSP11.
If all the testing architectures and implicitly supported deployments include these environment files then why not include them by default? This way we could avoid failed deployments caused by a missed environment file. Moreover in case of upgrades missing one environment file may possibly have destructive consequences for the overcloud.
Please consider that passing environment files is a manual operation which is error prone. We should try to avoid this for better usability.
I agree it should be by default and not a manual step for end users. I would not even consider this as an RFE, more of a user experience bug.
I've pushed a patch to inject the default docker.yaml and docker-ha.yaml environments downstream only:
https://code.engineering.redhat.com/gerrit/116444 Include docker.yaml and docker-ha.yaml by default
We'll also need to directly patch t-h-t for this too I think because customers could be using a variety of the environment/services/ templates which when using docker live under environment/services-docker. Automatically switching these could get dirty though as we'd need to exclude Neutron, Cinder, and Manila services. The safest/cleanest thing to do just seemed like editing tripleo-heat-templates. So this patch in addition to the one above:
https://code.engineering.redhat.com/gerrit/116463 Default supported services to docker
Should be able to verify this by removing docker.yaml and docker-ha.yaml from the CLI. Additionally the UI should now always have these enabled by default.
Deployed without including docker.yaml and docker-ha.yaml and ended up with containerized deployment.
Also verified here...
Worth noting that if you *do* include docker.yaml (and not docker-ha.yaml) on the CLI, an overcloud build will fail with the downstream templates as the VIP's aren't satisfied by pacemaker, even in a single controller environment.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.