Spec URL: https://carl.george.computer/review/python-pdir2.spec SRPM URL: https://carl.george.computer/review/python-pdir2-0.2.0-1.fc27.src.rpm Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20298423 Description: An improved version of dir() with better output. Attributes are grouped by types/functionalities, with beautiful colors. Supports ipython, ptpython, bpython, and Jupyter Notebook. Fedora Account System Username: carlwgeorge
Taking this review.
This packager needs sponsorship, though it is a new version of "carlgeorge" account.
I will sponsor this packager upon full review of the package.
FYI, I'm aware of the policy on multiple FAS accounts. Once my new carlwgeorge id is sponsored, I'll add it to all my current packages and mark the old carlgeorge id as inactive. https://fedoraproject.org/wiki/Account_System#Voluntary
Upstream released 0.2.1, which lets me drop two patches. Spec URL: https://carl.george.computer/review/python-pdir2.spec SRPM URL: https://carl.george.computer/review/python-pdir2-0.2.1-1.fc27.src.rpm Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20335807
Review notes: [x] Follows general Fedora packaging guidelines [x] Package is named appropriately per Python packaging guidelines [x] License is marked correctly, and license file is included as %license file Looks good to me. There's only one thing... SHOULD FIX (on import): [!] %{py2_build} -> %py2_build. For the sake of clarity, command macros should not be wrapped in braces. Especially when they actually *can* accept parameters. Otherwise, package approved!
I have sponsored in carlwgeorge.
I actually was not aware of that, thank you for letting me know. I also found the supporting documentation that explains it in greater detail. http://rpm.org/user_doc/macros.html#using-a-macro I'll delete the braces on those macros in the final SRPM I import.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-pdir2