Red Hat Bugzilla – Bug 1467146
Unable to view Reports if a member has a custom Role - indefinite spinning wheel
Last modified: 2017-07-06 14:21:28 EDT
Created attachment 1293727 [details]
Description of problem:
Having different Roles for our customers. However when we give them view permission to Reports, they are just getting a loading with "Spinning wheel" indefinitely.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1.Create Custom Role with attached screenshot permission list
2.Create Custom group with assigning this Custom Role
3.Create new user with assigning this custom group
4.Login with new created user and navigate to built-in reports accordion
Only see spinning wheel indefinitely
Navigate Reports menu based on permission
Able to observe "ERROR -- : An unauthorized connection attempt was rejected" from production.log
Created attachment 1293729 [details]
spinning wheel view
New commit detected on ManageIQ/manageiq-ui-classic/master:
Author: Martin Hradil <email@example.com>
AuthorDate: Thu Jul 6 15:37:08 2017 +0000
Commit: Martin Hradil <firstname.lastname@example.org>
CommitDate: Thu Jul 6 15:37:08 2017 +0000
Don't x_node_set on a tree which doesn't exist
Calling `x_node_set` when a tree doesn't exist works, but actually creates the entry that `tree_exists?` checks to see if such a tree exists.
When the user doesn't have the right to see such a tree, that's problematic, since it breaks the assumption that `tree_exists?` returns true only for trees that were actually initialized.
The leads to the calling `lock_tree` on a nonexistent tree, leading to a JS exceptions ("No element has been found").
This makes us actually check if the tree already exists before calling `x_node_set` on it.
(Would prefer to fix `x_node_set` instead, but.. this is a bugfix, and I really don't want to introduce more bugs. :))
app/controllers/report_controller.rb | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)