Red Hat Bugzilla – Bug 1467427
dracut hostonly misses modules that are built-in or renamed from the running kernel
Last modified: 2017-08-15 03:00:22 EDT
I'm filing this here because upstream doesn't appear to have a bug tracker. This bug also bit me because I sometimes run home-built kernels on Fedora 25. Dracut does this: static bool check_module_hostonly(struct kmod_module *mod) { const char *name = kmod_module_get_name(mod); if (check_hashmap(modules_loaded, name)) return true; return false; } This is prone to false negatives. A much better approach would be to also accept the module if its modalias matches anything on the running system. Basically, dracut should do the equivalent of: find /sys -name modalias |xargs cat and then check if any of the modalias lines in `modinfo $module` match any of the modaliases on the system. The specific failure I'm seeing is that I ran a kernel that had nvme built in and then allowed dnf to install a new kernel. The new kernel's initramfs was missing nvme-core and nvme. I suspect this could bite non kernel devs who upgrade to a kernel that renames a module, though.
https://github.com/dracutdevs/dracut Issue tracker and Pull requests seem attended
(In reply to Andy Lutomirski from comment #0) > I'm filing this here because upstream doesn't appear to have a bug tracker. > This bug also bit me because I sometimes run home-built kernels on Fedora 25. > > Dracut does this: > > static bool check_module_hostonly(struct kmod_module *mod) > { > const char *name = kmod_module_get_name(mod); > > if (check_hashmap(modules_loaded, name)) > return true; > > return false; > } > > This is prone to false negatives. A much better approach would be to also > accept the module if its modalias matches anything on the running system. > Basically, dracut should do the equivalent of: > > find /sys -name modalias |xargs cat > > and then check if any of the modalias lines in `modinfo $module` match any > of the modaliases on the system. > > The specific failure I'm seeing is that I ran a kernel that had nvme built > in and then allowed dnf to install a new kernel. The new kernel's initramfs > was missing nvme-core and nvme. I suspect this could bite non kernel devs > who upgrade to a kernel that renames a module, though. Yeah, you are right with your analysis. Will try to implement your suggestion.
might be fixed with: https://github.com/dracutdevs/dracut/commit/3ad12c7be89b79bee43b0871a8d2cac826b7d625
and https://github.com/dracutdevs/dracut/commit/db17ef6c4ffa41923020b04618fe627d4aa43206
This bug appears to have been reported against 'rawhide' during the Fedora 27 development cycle. Changing version to '27'.