Bug 1467706 - mariadb library upgrade to 10.2 causes bacula FTBFS
Summary: mariadb library upgrade to 10.2 causes bacula FTBFS
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: bacula
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Simone Caronni
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1467297
TreeView+ depends on / blocked
 
Reported: 2017-07-04 17:26 UTC by Augusto Caringi
Modified: 2017-07-21 07:28 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-07-21 07:28:09 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch to allow compilation of bacula with MariaDB 10.2 (743 bytes, patch)
2017-07-04 17:26 UTC, Augusto Caringi
no flags Details | Diff

Description Augusto Caringi 2017-07-04 17:26:54 UTC
Created attachment 1294296 [details]
Patch to allow compilation of bacula with MariaDB 10.2

Trying to build bacula with the new version of MariaDB 10.2 causes a build error:

mysql.c: In member function 'virtual bool BDB_MYSQL::bdb_open_database(JCR*)':
mysql.c:256:20: error: 'MYSQL {aka struct st_mysql}' has no member named 'reconnect'
    mdb->m_instance.reconnect = 1;             /* so connection does not timeout */
                    ^~~~~~~~~

In this new version of the library the reconnect field was moved to another struct. I think that the best approach is to set it through API. I attached a patch proposal to fix the problem.

We are tracking all the possible problems regarding this MariaDB upgrade in the bug 1467297.

Copr build: https://copr.fedorainfracloud.org/coprs/g/db-sig/mariadb-10.2/package/bacula/

Comment 1 Simone Caronni 2017-07-10 06:47:32 UTC
Testing with freshly released Bacula 9.

Comment 2 Augusto Caringi 2017-07-20 11:51:19 UTC
The problem persist with the new Bacula 9... 

mysql.c: In member function 'virtual bool BDB_MYSQL::bdb_open_database(JCR*)':
mysql.c:261:20: error: 'MYSQL {aka struct st_mysql}' has no member named 'reconnect'
    mdb->m_instance.reconnect = 1;             /* so connection does not timeout */
                    ^~~~~~~~~
make[1]: *** [Makefile:183: mysql.lo] Error 1

My proposed patch can fix this problem.

Comment 3 Simone Caronni 2017-07-21 07:28:09 UTC
Applied a rebased, patch, thanks. Also upstream has done it.


Note You need to log in before you can comment on or make changes to this bug.