Bug 1467725 - Button 'Save' is always disabled on Edit Subnet Page
Summary: Button 'Save' is always disabled on Edit Subnet Page
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.8.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.9.0
Assignee: Gilles Dubreuil
QA Contact: Ido Ovadia
URL:
Whiteboard: openstack:sdn
Depends On:
Blocks: 1515426
TreeView+ depends on / blocked
 
Reported: 2017-07-04 21:18 UTC by Oleksandr Kolisnyk
Modified: 2018-03-06 14:42 UTC (History)
8 users (show)

Fixed In Version: 5.9.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1515426 (view as bug list)
Environment:
Last Closed: 2018-03-06 14:42:15 UTC
Category: ---
Cloudforms Team: Openstack
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Oleksandr Kolisnyk 2017-07-04 21:18:30 UTC
Description of problem:
Can't edit cloud subnet because button 'Save' is disabled

Version-Release number of selected component (if applicable):
5.8.1.0 and RHOS 11

How reproducible:
Always

Steps to Reproduce:
1. Go Networks -> Subnets
2. Click on any subnet
3. Click Configuration -> Edit this Cloud Subnet
4. Change any value in form
5. Click on 'Save' button

Actual results:
'Save' button is not clickable

Expected results:
Confirmation of subnet's edition

Additional info:
JFYI: RHOS 11 was deployed with composable roles

Comment 3 Tzu-Mainn Chen 2017-10-03 14:47:45 UTC
Gilles, can you take a look at this one?

Comment 4 Gilles Dubreuil 2017-10-06 04:09:31 UTC
Issue is confirmed on fine branch but doesn't exist on the master branch where buttons are now managed via 'generic_form_buttons' used by 'vm = this' approach instead of $scope. 

The "Save" button doesn't get activated no matter the changes and besides the fact it seems properly configured. 

I can't find a fix unless spending more time on the issue therefore I would recommend back-porting from master branch although not ideal because it needs at least the following PRs needs to be backported:

https://github.com/ManageIQ/manageiq/pull/15248
https://github.com/ManageIQ/manageiq-ui-classic/pull/1545

After cherry-picking the latter two, the save button works although it should initially be greyed (inactive) until a change in the form has been made.

Comment 5 Gilles Dubreuil 2017-10-08 23:55:37 UTC
The following 2 Pull Requests provide the needed backport which includes the needed commits that have been cherry-picked.

https://github.com/ManageIQ/manageiq/pull/16150
https://github.com/ManageIQ/manageiq-ui-classic/pull/2320

Comment 6 Gilles Dubreuil 2017-11-03 01:33:05 UTC
Dependent patch has been back-ported: https://github.com/ManageIQ/manageiq/pull/16150

Comment 9 Gilles Dubreuil 2017-11-20 23:50:13 UTC
https://github.com/ManageIQ/manageiq-ui-classic/pull/2320 back ported too, thanks Satoe.

Comment 10 Ido Ovadia 2017-11-27 20:51:46 UTC
Verified
========
5.9.0.10


Note You need to log in before you can comment on or make changes to this bug.