Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1467969

Summary:	[RFE] Add a hierarchy of exceptions
Product:	[oVirt] ovirt-engine-sdk-python	Reporter:	Juan Hernández <juan.hernandez>
Component:	Core	Assignee:	Ondra Machacek <omachace>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Radim Hrazdil <rhrazdil>
Severity:	medium	Docs Contact:
Priority:	low
Version:	4.1.3	CC:	bugs, fabrice.bacchella, juan.hernandez, lsvaty, mperina, oourfali
Target Milestone:	ovirt-4.2.0	Keywords:	FutureFeature
Target Release:	---	Flags:	oourfali: ovirt-4.2? lsvaty: testing_plan_complete- rule-engine: planning_ack? rule-engine: devel_ack+ lsvaty: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	python-ovirt-engine-sdk4-4.2.1-1.a3	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-12-20 11:14:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Juan Hernández 2017-07-05 17:00:39 UTC

Currently when the SDK detects any kind of problem it raises ovirtsdk4.Error. The raise exception contains details about the error, like the HTTP error code, and the details of the error message generated by the engine. But when the error isn't HTTP related it is difficult to interpret it automatically, as the only information available is the error message. To improve this the SDK should instead provide a hierarchy of exception classes, and raise the ones that are relevant to the situation. This hierarchy should be rooted at the current ovirtsdk4.Error, and should contain at least the following exceptions:

  ovirtsdk4.NotFoundError - When the server returns a 400 HTTP error code.
  ovirtsdk4.TimeoutError - When a request fails after a timeout.
  ovirtsdk4.NoSuchHostError - When the host name can't be resolved.
  ovirtsdk4.UnauthorizedError - When the user isn't authorized.

The authentication error should be raised when the SSO service responds with an error or when the API responds with 401.

Comment 2 Ondra Machacek 2017-11-08 08:54:31 UTC

Following errors was implemented:

AuthError - Raised when authentication or authorization fail.

ConnectionError - Raised when the name of the server can’t be resolved, and when the server is down or unreachable.

NotFoundError - Raised when the requested object doesn’t exist.

TimeoutError - Raised when an operation times out.

Comment 3 Radim Hrazdil 2017-11-16 13:21:21 UTC

Verified new error classes in SDK ovirt-engine-sdk-python-4.2.1a3. Engine version 4.2.0-0.0.master.20171108151837.gita7de53e.el7.centos.

Comment 4 Sandro Bonazzola 2017-12-20 11:14:37 UTC

This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.