Red Hat Bugzilla – Bug 1467976
ceph logs shouldn't display dmcrypt key
Last modified: 2017-09-16 03:17:55 EDT
Description of problem: 2017-07-05 12:59:20.917401 mon.0 [INF] from='client.? 192.168.122.100:0/1418962056' entity='client.bootstrap-osd' cmd=[{"prefix": "config-key put", "key": "dm-crypt/osd/db13f070-7e71-44ca-9b2a-c5c4d482a40a/luks", "val": "DqcGGR1PT9j0z5AenpmSirK2b1J6gE13lN5m1YcYL6/nqTUgqdtJrYblLXdIv7awO6eL0PIIsfybmNfdFsTNigA5cSuUEdw66ODtK8sasYZHlaVIuFVNmEAU0xy/1Xhj+nKzAMVGjrZtUZnQ9kdJMJAbjvtLsV8CVQIcNE4G4Fg="}]: dispatch 2017-07-05 12:59:20.920841 mon.0 [INF] from='client.? 192.168.122.100:0/1418962056' entity='client.bootstrap-osd' cmd='[{"prefix": "config-key put", "key": "dm-crypt/osd/db13f070-7e71-44ca-9b2a-c5c4d482a40a/luks", "val": "DqcGGR1PT9j0z5AenpmSirK2b1J6gE13lN5m1YcYL6/nqTUgqdtJrYblLXdIv7awO6eL0PIIsfybmNfdFsTNigA5cSuUEdw66ODtK8sasYZHlaVIuFVNmEAU0xy/1Xhj+nKzAMVGjrZtUZnQ9kdJMJAbjvtLsV8CVQIcNE4G4Fg="}]': finished Steps to Reproduce: 1. ceph-disk prepare --dmcrypt <device> Actual results: dmcrypt key is displayed Expected results: dmcrypt key should be hidden
https://github.com/ceph/ceph/pull/16619
"Issue #20790 has been updated by Sage Weil. The 'config-key put' command can also take the value via stdin (-i -) or a file (-i <filename>); if the caller just does that this problem goes away. Also, in luminous, this key is provided via 'osd new' and 'config-key put' isn't used at all anymore. For jewel, a minimal fix is probably just the above..." Any objections to closing this NOTABUG?
(In reply to Brad Hubbard from comment #3) > Any objections to closing this NOTABUG? Ignore this, we need to look at the way ceph-disk executes this command.
So this luminous commit changed ceph-disk to use "ceph osd new". https://github.com/ceph/ceph/commit/9fa13d4c3ccde25770b8de5e9ad5d3d2dc0d96e0 the upstream tracker is closed since this is not a problem in master. Looking at a fix specifically for jewel.