Bug 1467976 - ceph logs shouldn't display dmcrypt key
Summary: ceph logs shouldn't display dmcrypt key
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Ceph Storage
Classification: Red Hat Storage
Component: Ceph-Disk
Version: 2.3
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: rc
: 3.0
Assignee: Brad Hubbard
QA Contact: Parikshith
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-07-05 17:37 UTC by Alexandre Marangone
Modified: 2017-12-05 23:35 UTC (History)
7 users (show)

Fixed In Version: RHEL: ceph-12.1.2-1.el7cp Ubuntu: ceph_12.1.2-2redhat1xenial
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-05 23:35:34 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Ceph Project Bug Tracker 20790 0 None None None 2017-07-27 06:11:12 UTC
Red Hat Product Errata RHBA-2017:3387 0 normal SHIPPED_LIVE Red Hat Ceph Storage 3.0 bug fix and enhancement update 2017-12-06 03:03:45 UTC

Description Alexandre Marangone 2017-07-05 17:37:13 UTC
Description of problem:
2017-07-05 12:59:20.917401 mon.0 [INF] from='client.? 192.168.122.100:0/1418962056' entity='client.bootstrap-osd' cmd=[{"prefix": "config-key put", "key": "dm-crypt/osd/db13f070-7e71-44ca-9b2a-c5c4d482a40a/luks", "val": "DqcGGR1PT9j0z5AenpmSirK2b1J6gE13lN5m1YcYL6/nqTUgqdtJrYblLXdIv7awO6eL0PIIsfybmNfdFsTNigA5cSuUEdw66ODtK8sasYZHlaVIuFVNmEAU0xy/1Xhj+nKzAMVGjrZtUZnQ9kdJMJAbjvtLsV8CVQIcNE4G4Fg="}]: dispatch
2017-07-05 12:59:20.920841 mon.0 [INF] from='client.? 192.168.122.100:0/1418962056' entity='client.bootstrap-osd' cmd='[{"prefix": "config-key put", "key": "dm-crypt/osd/db13f070-7e71-44ca-9b2a-c5c4d482a40a/luks", "val": "DqcGGR1PT9j0z5AenpmSirK2b1J6gE13lN5m1YcYL6/nqTUgqdtJrYblLXdIv7awO6eL0PIIsfybmNfdFsTNigA5cSuUEdw66ODtK8sasYZHlaVIuFVNmEAU0xy/1Xhj+nKzAMVGjrZtUZnQ9kdJMJAbjvtLsV8CVQIcNE4G4Fg="}]': finished

Steps to Reproduce:
1. ceph-disk prepare --dmcrypt <device>

Actual results:
dmcrypt key is displayed

Expected results:
dmcrypt key should be hidden

Comment 2 Brad Hubbard 2017-07-27 06:11:12 UTC
https://github.com/ceph/ceph/pull/16619

Comment 3 Brad Hubbard 2017-08-09 03:16:03 UTC
"Issue #20790 has been updated by Sage Weil.

The 'config-key put' command can also take the value via stdin (-i -) or a file (-i <filename>); if the caller just does that this problem goes away.

Also, in luminous, this key is provided via 'osd new' and 'config-key put' isn't used at all anymore. For jewel, a minimal fix is probably just the above..."

Any objections to closing this NOTABUG?

Comment 4 Brad Hubbard 2017-08-09 03:31:30 UTC
(In reply to Brad Hubbard from comment #3)
> Any objections to closing this NOTABUG?

Ignore this, we need to look at the way ceph-disk executes this command.

Comment 5 Brad Hubbard 2017-08-11 02:42:03 UTC
So this luminous commit changed ceph-disk to use "ceph osd new".

https://github.com/ceph/ceph/commit/9fa13d4c3ccde25770b8de5e9ad5d3d2dc0d96e0

the upstream tracker is closed since this is not a problem in master. Looking at a fix specifically for jewel.

Comment 12 errata-xmlrpc 2017-12-05 23:35:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:3387


Note You need to log in before you can comment on or make changes to this bug.