Description of problem: Due to the change in fluentd that runs it as root, if the package is not upgraded in the hosts or engine the metrics setup script fails due to insufficient permissions. /usr/share/gems/gems/fluentd-0.12.29/lib/fluent/supervisor.rb:474:in `read': Permission denied - /etc/fluentd/fluent.conf (Errno::EACCES) Version-Release number of selected component (if applicable): 4.1.3 How reproducible: 100% Steps to Reproduce: 1. Have 4.1 host/engine with fluentd-0.12.29 package. 2. configure config.yml. 3. Run the configure_ovirt_machines_for_metrics.sh script Actual results: Deployment fails Expected results: Should not have errors on permissions Additional info:
There is an option to upgrade the packages in the setup script. Currently it only installs missing packages if do not exists. As I understand it is not that uncommon for users to not update the hosts packages. The question is if we want to add a requirement that the hosts and engine packages must me upgraded before running the metrics setup script or to upgrade the relevant packages in the script itself?
(In reply to Shirly Radco from comment #1) > There is an option to upgrade the packages in the setup script. Currently it > only installs missing packages if do not exists. > > As I understand it is not that uncommon for users to not update the hosts > packages. The question is if we want to add a requirement that the hosts and > engine packages must me upgraded before running the metrics setup script or > to upgrade the relevant packages in the script itself? Documentation seems sufficient to me. Is the 'Upgrade' from Engine has those packages as well? at least for 4.2, we'd like them to be there.
(In reply to Yaniv Kaul from comment #2) > (In reply to Shirly Radco from comment #1) > > There is an option to upgrade the packages in the setup script. Currently it > > only installs missing packages if do not exists. > > > > As I understand it is not that uncommon for users to not update the hosts > > packages. The question is if we want to add a requirement that the hosts and > > engine packages must me upgraded before running the metrics setup script or > > to upgrade the relevant packages in the script itself? > > Documentation seems sufficient to me. Is there a problem if we upgrade? The patch should be trivial. In the past we decided to also not install. If we now install, upgrading does not add much risk, IMO. > Is the 'Upgrade' from Engine has those packages as well? Should have. > at least for 4.2, > we'd like them to be there.
(In reply to Yedidyah Bar David from comment #3) > (In reply to Yaniv Kaul from comment #2) > > (In reply to Shirly Radco from comment #1) > > > There is an option to upgrade the packages in the setup script. Currently it > > > only installs missing packages if do not exists. > > > > > > As I understand it is not that uncommon for users to not update the hosts > > > packages. The question is if we want to add a requirement that the hosts and > > > engine packages must me upgraded before running the metrics setup script or > > > to upgrade the relevant packages in the script itself? > > > > Documentation seems sufficient to me. > > Is there a problem if we upgrade? > > The patch should be trivial. OK, if you can make it on time for 4.1.4. > > In the past we decided to also not install. If we now install, upgrading > does not add much risk, IMO. > > > Is the 'Upgrade' from Engine has those packages as well? > > Should have. > > > at least for 4.2, > > we'd like them to be there.
verified in ovirt-engine-metrics-1.0.5-1.el7ev.noarch