Bug 1468432 - tests: fix stats-dump.t failure
Summary: tests: fix stats-dump.t failure
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: tests
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-07-07 05:16 UTC by Ravishankar N
Modified: 2017-09-05 17:36 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.12.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-09-05 17:36:29 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Ravishankar N 2017-07-07 05:16:49 UTC
Since https://review.gluster.org/#/c/17452, the statistics are appended
    to the same file instead of overwritten over the previous stats. This
    was causing the .t to fail since it checks for only the presence of a
    non zero aggr.fop.write.count assuming the latest statistics will
    overwrite the previous ones.

    Fix it by checking for that the latest value of aggr.fop.write.count is
    non zero.

Comment 1 Worker Ant 2017-07-07 05:17:19 UTC
REVIEW: https://review.gluster.org/17721 (tests: fix stats-dump.t failure) posted (#1) for review on master by Ravishankar N (ravishankar)

Comment 2 Worker Ant 2017-07-07 05:45:27 UTC
REVIEW: https://review.gluster.org/17723 (tests: Disable basic/stats-dump.t) posted (#1) for review on master by Nigel Babu (nigelb)

Comment 3 Worker Ant 2017-07-07 05:45:37 UTC
COMMIT: https://review.gluster.org/17723 committed in master by Nigel Babu (nigelb) 
------
commit 45517ad2439118cebef63390b82a5e94c5b83ee8
Author: Nigel Babu <nigelb>
Date:   Fri Jul 7 11:06:37 2017 +0530

    tests: Disable basic/stats-dump.t
    
    Disabling this test right now so that master is green again. This patch
    https://review.gluster.org/#/c/17721/ will actually fix the test. This
    patch will make master green again unblocking other patches to land onto
    master.
    
    Change-Id: I77d177ce92eb6edcf5326b27a0f7fdbefdec007b
    Signed-off-by: Nigel Babu <nigelb>
    BUG: 1468432
    Reviewed-on: https://review.gluster.org/17723

Comment 4 Worker Ant 2017-07-07 07:43:52 UTC
REVIEW: https://review.gluster.org/17721 (tests: fix stats-dump.t failure) posted (#2) for review on master by Ravishankar N (ravishankar)

Comment 5 Worker Ant 2017-07-10 14:32:34 UTC
COMMIT: https://review.gluster.org/17721 committed in master by Raghavendra Talur (rtalur) 
------
commit b0d8afa2d2861f1191c4139e9aa9d4ba67e83135
Author: Ravishankar N <ravishankar>
Date:   Fri Jul 7 02:46:26 2017 +0530

    tests: fix stats-dump.t failure
    
    Since https://review.gluster.org/#/c/17452, the statistics are appended
    to the same file instead of overwritten over the previous stats. This
    was causing the .t to fail since it checks for only the presence of a
    non zero aggr.fop.write.count assuming the latest statistics will
    overwrite the previous ones.
    
    Fix it by checking for that the latest value of aggr.fop.write.count is
    non zero.
    
    Change-Id: I858011f343966a5d1c19d66dcc64b8cd26315df7
    BUG: 1468432
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: https://review.gluster.org/17721
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Amar Tumballi <amarts>
    Reviewed-by: Raghavendra Talur <rtalur>

Comment 6 Shyamsundar 2017-09-05 17:36:29 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.12.0, please open a new bug report.

glusterfs-3.12.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-September/000082.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.