Bug 1468460 - Support 'error' field in JSON SSO response
Summary: Support 'error' field in JSON SSO response
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-sdk-python
Classification: oVirt
Component: Core
Version: 4.1.4
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.2.0
: 4.2.0
Assignee: Ondra Machacek
QA Contact: Gonza
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-07-07 07:37 UTC by Ondra Machacek
Modified: 2018-02-12 10:09 UTC (History)
3 users (show)

Fixed In Version: python-ovirt-engine-sdk4-4.2.1-1.a1.20170718git56b2d49
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-02-12 10:09:49 UTC
oVirt Team: Infra
Embargoed:
rule-engine: ovirt-4.2+
lsvaty: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 79269 0 master MERGED Raise proper exception when using OpenId 2017-07-18 13:00:55 UTC
oVirt gerrit 79558 0 sdk_4.1 ABANDONED Raise proper exception when using OpenId 2017-07-18 13:01:21 UTC

Description Ondra Machacek 2017-07-07 07:37:31 UTC 
OpenId Connect defines the return variable names in case of error. It requires error and error_description.

We used to use error_code instead, before, so we now need to support both 'error' and 'error_code'.
Comment 1 Oved Ourfali 2017-07-07 18:17:41 UTC 
Targeting to 4.2. 
Do we need it also on 4.1.z?
Comment 2 Ondra Machacek 2017-07-11 13:57:27 UTC 
No, OpenId is just for 4.2.
Comment 3 Gonza 2018-01-29 15:17:19 UTC 
Verified with:
ovirt-engine-4.2.1.1-0.1.el7.noarch

{"error_description":"Cannot authenticate user 'admin@internal': The username or password is incorrect..","error":"access_denied"}%
Comment 4 Sandro Bonazzola 2018-02-12 10:09:49 UTC 
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Note You need to log in before you can comment on or make changes to this bug.