Bug 1468619 - [PATCH] Introspect Atomic payload to determine supported locales
Summary: [PATCH] Introspect Atomic payload to determine supported locales
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: fedora-productimg-atomic
Version: 25
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Colin Walters
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-07-07 14:50 UTC by Jonathan Lebon
Modified: 2017-07-24 17:21 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-07-11 17:42:19 UTC
Type: Bug


Attachments (Terms of Use)
Introspect Atomic payload to determine supported locales (5.28 KB, patch)
2017-07-07 14:50 UTC, Jonathan Lebon
no flags Details | Diff
Introspect Atomic Host payload for supported locales (5.40 KB, patch)
2017-07-10 14:54 UTC, Jonathan Lebon
no flags Details | Diff

Description Jonathan Lebon 2017-07-07 14:50:04 UTC
This is essentially a split out of the installclass modifications that
were done in https://github.com/rhinstaller/anaconda/pull/871. It needs
the corresponding Anaconda patch to be useful, though it should be
harmless to apply ahead of time.

Related: https://pagure.io/atomic-wg/issue/282

Comment 1 Jonathan Lebon 2017-07-07 14:50:34 UTC
Created attachment 1295328 [details]
Introspect Atomic payload to determine supported locales

Comment 2 Jonathan Lebon 2017-07-07 14:52:27 UTC
Requires https://github.com/rhinstaller/anaconda/pull/1122.

Comment 3 Jonathan Lebon 2017-07-07 17:04:57 UTC
Sanity checked that the patch on its own doesn't cause any isues on older anacondas without https://github.com/rhinstaller/anaconda/pull/1122.

Comment 4 Colin Walters 2017-07-10 14:11:25 UTC
Super minor things:

Can you s/Atomic/Atomic Host/ in the changelog?

- Delete the locale checkout dir when done?  I know it's just transient but we might as well keep this clean on general principle
- Seems like the (lang, territory) = line.split('_') should be (lang, territory) = line.split('_'. 1) just for sanity?

Comment 5 Jonathan Lebon 2017-07-10 14:54:16 UTC
Created attachment 1295851 [details]
Introspect Atomic Host payload for supported locales

Comment 6 Jonathan Lebon 2017-07-10 14:55:11 UTC
Thanks for the feedback! Updated in ⬆️.

Comment 8 Jonathan Lebon 2017-07-19 17:14:24 UTC
Can we have this in f26 as well? Would be nice if we could release this as part of a TWR.


Note You need to log in before you can comment on or make changes to this bug.