Bug 1468725 - [paid] Reconciler missing timestamp annotation to complete support subscriptions
[paid] Reconciler missing timestamp annotation to complete support subscriptions
Product: OpenShift Online
Classification: Red Hat
Component: Accounts and Billing (Show other bugs)
Unspecified Unspecified
unspecified Severity medium
: ---
: ---
Assigned To: Mark Turansky
Depends On:
  Show dependency treegraph
Reported: 2017-07-07 14:12 EDT by Mark Turansky
Modified: 2017-11-09 13:49 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2017-11-09 13:49:33 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Mark Turansky 2017-07-07 14:12:34 EDT
Description of problem:

When an error occurs while subscribing to support, the reconciler is expected to pick up the failed transaction and complete it. The reconciler looks for a timestamp (to determine how old the pending TX is) and fails when that timestamp is missing from the User's annotations.

Version-Release number of selected component (if applicable):

How reproducible:


Steps to Reproduce:

Difficult to reproduce. It requires either a failed Aria API call or a failed OpenShift User update. Both are difficult to purposefully create.

Actual results:

Expected results:

Additional info:
Comment 1 Mark Turansky 2017-07-07 14:13:04 EDT
Fix in https://github.com/openshift/online/pull/1343
Comment 2 Abhishek Gupta 2017-07-19 16:01:47 EDT
The fix is now available in INT
Comment 3 zhaliu 2017-07-19 22:45:34 EDT
From the log of account pod in online-int, I find an error occurs again and again, that is "reconciler error for user "yasun-406": error reconciling user &TypeMeta{Kind:,APIVersion:,}: invalid user metadata: missing "openshift.io/support-start-time" annotation", it seems that the reconciler can't handle the the user with missing "openshift.io/support-start-time" annotation successfully.
I will add all the log to attachment.
Comment 5 Mark Turansky 2017-08-15 17:06:07 EDT
Can you verify this with a new account?

I suspect the account you used was created before the fix was deployed. As a result, it wouldn't have the required annotation and would still continue to fail in the reconciler.  Making your account work would require a "migration" of all user accounts that are missing the annotation. We're not currently planning on doing this 'migration' because we don't see this error in prod logs.
Comment 6 zhaliu 2017-08-15 23:11:49 EDT
I have looked up the account pod logs from online-int and online-stg, the account pod in online-stg has been running for 13d, except for several old user accounts, there are no new accounts meeting the similar problem. The pod account pod in online-int has been running for 3 hours, there are no similar problems too.
Because of no problem found now in online stg and online int and the difficulty in reproducing this problem ,I will change the status into "verified" temporally. If the problem occurs again I will reopen that.

Note You need to log in before you can comment on or make changes to this bug.