https://github.com/ManageIQ/manageiq-gems-pending/pull/244
https://github.com/ManageIQ/manageiq-gems-pending/pull/247
https://github.com/ManageIQ/manageiq/pull/15612
Closing as a duplicate. *** This bug has been marked as a duplicate of bug 1469307 ***
New commit detected on ManageIQ/manageiq-gems-pending/master: https://github.com/ManageIQ/manageiq-gems-pending/commit/59aab09a52b63113698ee042c91719e0518901a3 commit 59aab09a52b63113698ee042c91719e0518901a3 Author: Joe Rafaniello <jrafanie> AuthorDate: Tue Jul 18 17:29:33 2017 -0400 Commit: Joe Rafaniello <jrafanie> CommitDate: Wed Jul 19 13:46:48 2017 -0400 Only return the cached value if it exists. If the cache was cleared and an exception was raised when trying to set the new `cache[:value]`, we'd end up setting the `cache[:timeout]` but not the new value. Any subsequent call would return a nil from `cache[:value]` because `cache[:timeout]` exists, making `cache` non-empty. The new code only returns from the cache if the :value key exists in the `cache`. Additionally, for consistency, we only set the `cache[:timeout]` and `cache[:value]` after we've calculated these values, therefore the `cache` doesn't get partially set. This is not required but makes me feel better. https://bugzilla.redhat.com/show_bug.cgi?id=1469307 https://bugzilla.redhat.com/show_bug.cgi?id=1468898 This replaces https://github.com/ManageIQ/manageiq-gems-pending/pull/244 lib/gems/pending/util/extensions/miq-module.rb | 5 +++-- spec/util/extensions/miq-module_spec.rb | 27 ++++++++++++++++++++++++++ 2 files changed, 30 insertions(+), 2 deletions(-)
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/d49338133fe451db9d46df0252ed5c4f3b9825b8 commit d49338133fe451db9d46df0252ed5c4f3b9825b8 Author: Joe Rafaniello <jrafanie> AuthorDate: Wed Jul 19 16:38:48 2017 -0400 Commit: Joe Rafaniello <jrafanie> CommitDate: Fri Jul 21 11:00:44 2017 -0400 Tag the monitor thread with the worker info so we can kill it later When the server starts the monitor thread, store the worker class and id in the thread object so the server can then kill that thread if required later. Implement stop/kill/terminate in the same way: look for the thread containing the worker's class and id in Thread.list, exit it, and destroy the worker row. https://bugzilla.redhat.com/show_bug.cgi?id=1469307 https://bugzilla.redhat.com/show_bug.cgi?id=1468898 app/models/embedded_ansible_worker.rb | 33 +++++++++++++++++-- spec/models/embedded_ansible_worker_spec.rb | 50 +++++++++++++++++++++++++++++ 2 files changed, 80 insertions(+), 3 deletions(-)
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/63816f42aa17f7a6ce4d0ed324448da913f78831 commit 63816f42aa17f7a6ce4d0ed324448da913f78831 Author: Joe Rafaniello <jrafanie> AuthorDate: Wed Jul 19 16:36:56 2017 -0400 Commit: Joe Rafaniello <jrafanie> CommitDate: Fri Jul 21 11:00:44 2017 -0400 Delegate the pid knowledge to the worker row. Each worker can implement their own way to invoke processes so let them choose and persist their pid value, don't assume we can use Process.pid. https://bugzilla.redhat.com/show_bug.cgi?id=1469307 https://bugzilla.redhat.com/show_bug.cgi?id=1468898 app/models/miq_worker/runner.rb | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
New commit detected on ManageIQ/manageiq/fine: https://github.com/ManageIQ/manageiq/commit/48faba0f59be5dcbb35becb102670d31d6ad00f2 commit 48faba0f59be5dcbb35becb102670d31d6ad00f2 Author: Joe Rafaniello <jrafanie> AuthorDate: Wed Jul 19 16:36:56 2017 -0400 Commit: Joe Rafaniello <jrafanie> CommitDate: Fri Jul 21 12:30:17 2017 -0400 Delegate the pid knowledge to the worker row. Each worker can implement their own way to invoke processes so let them choose and persist their pid value, don't assume we can use Process.pid. https://bugzilla.redhat.com/show_bug.cgi?id=1469307 https://bugzilla.redhat.com/show_bug.cgi?id=1468898 app/models/miq_worker/runner.rb | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
New commit detected on ManageIQ/manageiq/fine: https://github.com/ManageIQ/manageiq/commit/86ec71fa64022c8aa19046b4fa27542cfc601817 commit 86ec71fa64022c8aa19046b4fa27542cfc601817 Author: Joe Rafaniello <jrafanie> AuthorDate: Wed Jul 19 16:38:48 2017 -0400 Commit: Joe Rafaniello <jrafanie> CommitDate: Fri Jul 21 12:31:20 2017 -0400 Tag the monitor thread with the worker info so we can kill it later When the server starts the monitor thread, store the worker class and id in the thread object so the server can then kill that thread if required later. Implement stop/kill/terminate in the same way: look for the thread containing the worker's class and id in Thread.list, exit it, and destroy the worker row. https://bugzilla.redhat.com/show_bug.cgi?id=1469307 https://bugzilla.redhat.com/show_bug.cgi?id=1468898 app/models/embedded_ansible_worker.rb | 32 ++++++++++++++++-- spec/models/embedded_ansible_worker_spec.rb | 50 +++++++++++++++++++++++++++++ 2 files changed, 80 insertions(+), 2 deletions(-)